Epic for Editing and Aligning Verse Ranges

[birchamp]

Feature Canvas: https://docs.google.com/document/d/1-76Ysa_AurM3yQCyajoEqFw4ZzcJvdC5DCb7xE285Rw/edit

ClickUp: https://app.clickup.com/t/1jfq4cj

Sample text for testing: gal 1:1 in UST

Existing issues that affect this need:

TODO - tCore Updates Needed:

• scripture pane:

  • update to show verse spans when selected verse is within a span
  • update to show all verses in the range when selected verse is a verse span

• enhanced scripture pane:

  • update to show verse spans
  • update to edit verse spans

• word alignment:

  • glom original language verses together for ease of alignment
  • add support for verse spans in on edit notifications to invalidate alignments (in checking-tool-wrapper?)
  • API: getInvalidChecks(), getProgress(), _initChapterAlignments(), validateVerse(), getGlobalAlignmentMemory() , <= add verse span support
  • misc: indexChapterAlignments(), migrateChapterAlignments() <= add verse span support

• tN & tW:

  • add support for verse spans in on edit notifications to invalidate notes (in checking-tool-wrapper?)
  • make sure selections work with verse spans
  • display verse span in check area
  • on selection save, use verse span

• tCore:

  • remove warnings of missing verses when there are verse spans on project import and project selection
  • export - add refs on verse span alignments
  • import - parse refs for verse spans
  • also overwrite merges
  • add verse span support checking for external edits on WA tool open

• checking-tool-wrapper:

  • fix verse span support for edits in misc.:
  • look at groupsDataActions.verifyGroupDataMatchesWithFs()
  • look at verseEditActions.editTargetVerse()
    • fix problem parseInt converts verse span to number

• what is the impact on csv's, since currently verse is a number?

• set min compatible version for tCore to 3.1.0

• General - examine places:

  • where verse is converted to number: parseInt, isNaN
  • check for loops that iterate through verses numerically
  • check for verse proptypes that are numbers only in react components

[birchamp]

@birchamp add in canvas and scripture

[birchamp]

@mannycolon @PhotoNomad0 Please review these mockups:

• Alignment:

• Expanded/multi-verse view

• Edit scripture

[PhotoNomad0]

@birchamp Some of these can be done, but we were talking about minimal UI changes to make this doable in a short time. Currently the Expanded scripture pane is laid out in rows, so it is much easier to do this layout:

Still looking into how we could do the regular scripture pane without a lot of refactoring of UI. Currently I can make all the bibles show up as verse spans, such as:

but that is not ideal. Looking at options.

[birchamp]

Thanks for the heads up on that. @PhotoNomad0

[birchamp]

@PhotoNomad0 Could you put a verse number mid-text in the UGNT where the next verse starts? So leave the reference as '1:1-2', but also have a bold '2' where the 2nd verse begins.

[PhotoNomad0]

@birchamp @mannycolon - I have succeeded in getting a rough prototype working for the UI. Still have a bunch of business logic issues to resolve. Here is the rough UI for alignment now:

[PhotoNomad0]

@PhotoNomad0 Could you put a verse number mid-text in the UGNT where the next verse starts? So leave the reference as '1:1-2', but also have a bold '2' where the 2nd verse begins.

I think in this case I can place two separate verses here (e.g. 1:1 and 1:2). I'll look at it later to see what might be easier. For now I just have the 1:2 before the second verse. See screen above.

[PhotoNomad0]

@birchamp @elsylambert - I have a very rough prototype if you want to take a look: https://github.com/unfoldingWord/translationCore/actions/runs/1304694194

[PhotoNomad0]

Notes: Repos with verse spans:

• https://git.door43.org/christopherrsmith/en_ust_act_book
• https://git.door43.org/lrsallee/en_ust_luk_book
• https://git.door43.org/lrsallee/en_ust_gal_book
• https://git.door43.org/lrsallee/en_ust_jos_book
• https://git.door43.org/MattCarlton/en_ust_gen_book - has a verse span of 4, see chapter 36

[elsylambert]

Looks good in translationCore 3.1.0 (a7d2893).