unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Support Pre-release testing in Catalog Next #7343

Closed PhotoNomad0 closed 2 years ago

PhotoNomad0 commented 2 years ago

Story Explanation

User Story

As an admin I want to be able to do pre-production (draft) release testing in Catalog Next.

Here is a preliminary mock up of admin options:

Screen Shot 2022-07-03 at 8 45 26 PM

Features / Specifications

Definition of Done

Additional Context

Mockups

PhotoNomad0 commented 2 years ago

Notes:

birchamp commented 2 years ago
PhotoNomad0 commented 2 years ago

@elsylambert - whenever the user changes state of "Show Pre-Release Resources", there will be a refetch of resources.

PhotoNomad0 commented 2 years ago

@elsylambert fix is in translationCore 3.2.1 (2f23553). If you do a regular download of ml_tn/test_org2 you will get version 0.4.1. Then turn on "show prerelease resources" and then download ml_tn/test_org2 and you will get version 0.5.1.

elsylambert commented 2 years ago

@PhotoNomad0 Unable to install translationCore 3.2.1(2f23553) due to an error. image

PhotoNomad0 commented 2 years ago

@elsylambert - do you have a log file? I didn't see a problem in MacOS. Will try WIndows

elsylambert commented 2 years ago

@PhotoNomad0 Win 11. Log file: Tue Jul 12 2022.zip

PhotoNomad0 commented 2 years ago

@elsylambert This log file is for v3.2.1 (24bd9f9)?

PhotoNomad0 commented 2 years ago

@elsylambert I was able to install on Windows 10. Will try Windows 11 next.

elsylambert commented 2 years ago

@PhotoNomad0 win 11 machine was on 3.2.0(a1634b3) and I upgraded to translationCore 3.2.1 (2f23553), thats when I got the error in tC/resources/..../books.zip. So I installed translationCore 3.2.1 (https://github.com/unfoldingWord/translationCore/commit/24bd9f985fc240d2023ae3dc5c6a4ee66bda360d). instead and it worked fine. now I upgraded from translationCore 3.2.1 (https://github.com/unfoldingWord/translationCore/commit/24bd9f985fc240d2023ae3dc5c6a4ee66bda360d). to translationCore 3.2.1 (2f23553), it worked fine.

PhotoNomad0 commented 2 years ago

@elsylambert It looks like that error occurred before tCore even started. So that is an installer error message (and not a helpful one). So would not see anything in the log. Could the PC's hard drive be full?

PhotoNomad0 commented 2 years ago

...it's a file copy error.

elsylambert commented 2 years ago

Works as expected in translationCore 3.2.1 (2f23553). @PhotoNomad0 I have three observations:

  1. I do not see the third check box- "Delete downloaded Resources" in the admin options.
  2. The checkbox selections do not get cleared when I re-open the Update content window. i.e I selected the option "Show Pre-release Resources" and then downloaded the resource. I reopened the Content Update window and the "Show Pre-release Resources" was already checked.
  3. The content Update window opens in the background when the Alert is displayed and it gets closed when you make selection on the alert. image
PhotoNomad0 commented 2 years ago

Works as expected in translationCore 3.2.1 (2f23553). @PhotoNomad0 I have three observations:

1. I do not see the third check box- "Delete downloaded Resources" in the admin options.

Sorry @elsylambert , that was something @birchamp decided to remove from the issue but it was not updated here.

2. The checkbox selections do not get cleared when I re-open the Update content window. i.e I selected the option "Show Pre-release Resources" and then downloaded the resource. I reopened the Content Update window and the "Show Pre-release Resources" was already checked.

@elsylambert I made the checkbox sticky for the tCore session. I was thinking it would be annoying for the admin if they were doing repeated downloads that they would have to reselect the pre-release checkbox and wait for a new fetch. I could reset this after each use. @birchamp - what do you think?

3. The content Update window opens in the background when the Alert is displayed and it gets closed when you make selection on the alert.

@birchamp - is this something we want to work on as part of the issue? I believe it is a pre-existing issue, but would take some refactoring to fix. It is annoying, but does not block the user.

elsylambert commented 2 years ago

Thanks for the update @PhotoNomad0 for 2., it seems reasonable for the checkbox to be sticky per tC session. for 3, Its not a blocker and if requires refactoring then I wont push you to fix UI at this point.

PhotoNomad0 commented 2 years ago

FYI - item 3 occurs starting with the second time you open the dialog if you haven't selected to not show the warning again.

PhotoNomad0 commented 2 years ago

Let me check - I may have a quick fix for 3 that may work. @elsylambert

PhotoNomad0 commented 2 years ago

Let me check - I may have a quick fix for 3 that may work. @elsylambert

No, the quick fix did not work.

birchamp commented 2 years ago
  1. Since it clears the next time tC is run, I think that we can leave it checked during the session.
  2. Since this is a pre-existing issue, it's not necessary to fix it. @elsylambert do we have an issue for this already? If so, can you link to it here?
elsylambert commented 2 years ago

I am passing this issue since it works as defined and expected and based on the above comments, 2- functionality is fine and 3 doesn’t need to be fixed at this point.

PhotoNomad0 commented 2 years ago

@elsylambert have a fix for downloading pre-release of en_tn/test_org in build translationCore 3.3.0 (350f91e)

elsylambert commented 2 years ago

Not seeing the problem in translationCore 3.3.0 (350f91e) while downloading en_tn/test_org pre-release Resource.