Add ability to Load Master branch resources to tCore Scripture pane.

PhotoNomad0 commented 2 years ago

Story Explanation

User Story

We could add option to enter a repo URL to Scripture pane drop-down to read bible resources. This would input:

a tCore book repo that is for the same book of the bible as the current project
a whole bible repo that contains the book of the bible.

Also add a refresh button to three dot menu (with online warning)

To simplify implementation:

don't save data to disk, but just keep in memory for session. After user reopens tCore, when they open tool give prompt to user in scripture pane that they need to refresh the resource.
save URL to the USFM file into the repo manifest
could add an item to end of list - load from URL that would trigger tC to prompt for URL and validate.

We could do this as a patch for the 3.3.0 release.

Features / Specifications

[ ]
[ ]
[ ]

Definition of Done

[ ]
[ ]
[ ]

Additional Context

Mockups

PhotoNomad0 commented 2 years ago

@birchamp @elsylambert OK need some suggestions on verbage. Here are the screenshots:

A.

B.

C.

D.

E.

PhotoNomad0 commented 2 years ago

Replacement for B:

PhotoNomad0 commented 2 years ago

Added support for following URL formats:

specific resource or project USFM file such as: https://git.door43.org/<owner>/<repo>/raw/branch/master/02-EXO.usfm or https://git.door43.org/ayan.75/bn_bgst_1ti_book/raw/branch/master/bn_bgst_1ti_book.usfm
general repo with book lookup from manifest: https://git.door43.org/<owner>/<repo>

If exact load of URL fails, then will try to extract URL of repo from the start of the URL such as in # 2 and then lookup using manifest.

elsylambert commented 2 years ago

A. Load Bible Resource (USFM) B. Project: en_ult_1ti_book Enter Resource URL C. Loading Resource : {URL} D. What is the difference between C and D? E. View Resource URL

@birchamp Please update/edit my suggestions when you get a chance.

PhotoNomad0 commented 2 years ago

A. Load Bible Resource (USFM) B. Project: en_ult_1ti_book Enter Resource URL C. Loading Resource : {URL} D. What is the difference between C and D? E. View Resource URL

@birchamp Please update/edit my suggestions when you get a chance.

Oops, it looks like D was just a duplicate. @elsylambert

PhotoNomad0 commented 2 years ago

Note: @elsylambert and I discussed E and decided to just put back the language ID in place of the VIEWURL.

PhotoNomad0 commented 2 years ago

@elsylambert Fix is in translationCore 3.3.0 (421972d).

There should be a separate issue(s) for next steps:

improved support in SP including being able to add Bible URL from SP add pane
fix issue that the remove resource menu item does not work on the URL Bible panes. @birchamp

elsylambert commented 2 years ago

@PhotoNomad0 A. I added the USFM for tit :https://git.door43.org/Es-419_gl/es-419_glt/raw/branch/master/57-TIT.usfm, it shows in a TIT project, but I am not able to remove the Resource from the Scripture Pane.

elsylambert commented 2 years ago

For your review: B. Console shows error that Locale is missing

.

elsylambert commented 2 years ago

C. I mistakenly was trying to load a Ruth USFM to a EST project. At first, it went fine but showed nothing in the SP. Then I tried again and it showed the following error:

The error message is missing the text in {}.

PhotoNomad0 commented 2 years ago

@PhotoNomad0 A. I added the USFM for tit :https://git.door43.org/Es-419_gl/es-419_glt/raw/branch/master/57-TIT.usfm, it shows in a TIT project, but I am not able to remove the Resource from the Scripture Pane.

Yes, as stated above that is a known issue. We need to create separate issue(s) for next steps:

improved support in SP including being able to add Bible URL from SP add pane
fix issue that the remove resource menu item does not work on the URL Bible panes. @birchamp

PhotoNomad0 commented 2 years ago

For your review: B. Console shows error that Locale is missing .

I've seen that before, but not able to reproduce that in the latest build.

PhotoNomad0 commented 2 years ago

C. I mistakenly was trying to load a Ruth USFM to a EST project. At first, it went fine but showed nothing in the SP. Then I tried again and it showed the following error:

The error message is missing the text in {}.

Yes, I see the broken error message. I cannot reproduce the problem that it does not show an error the first time.

PhotoNomad0 commented 2 years ago

Note: testing with https://git.door43.org/Es-419_gl/es-419_glt/raw/branch/master/08-RUT.usfm

PhotoNomad0 commented 2 years ago

C. I mistakenly was trying to load a Ruth USFM to a EST project. At first, it went fine but showed nothing in the SP. Then I tried again and it showed the following error: The error message is missing the text in {}.

Yes, I see the broken error message. I cannot reproduce the problem that it does not show an error the first time.

OK, I saw that happen once, very strange... @elsylambert

elsylambert commented 2 years ago

translationCore 3.3.0 (df4a8a6). The issue C. is resolved. tC gives the correct error message when a different USFM(Book) is loaded into the a Project(different from the Manifest). User is able to delete the USFM Resource from the ADD Resource Modal. Remove Resource option is no longer available for the USFM Resource in Scripture Pane.

elsylambert commented 2 years ago

Wrote up #7403 for a minor UI issue with the Resource title in expanded scripture pane.

unfoldingWord / translationCore