Closed PhotoNomad0 closed 1 year ago
@elsylambert @birchamp - It looks like we will have to show the warning immediately when they try to open the project. The reason is that there is a performance optimization that the tools are initialized immediately when the project is opened, so the wA tool will start checking for invalidations in the background before the wA tool is even opened. So we have to block opening the project until they have updated the ugnt (or hbo) to match or exceed the version in the project manifest.
Notes:
To test:
~/translationCore/resources/el-x-koine/bibles/ugnt
@birchamp @elsylambert - is this verbage in the screenshot above ^^^ sufficient for the issue?
@elsylambert This is implemented in the latest tCore develop build 3.4.0 [984c28c]. See the notes above for a way to test.
@PhotoNomad0 got this error when I tried to open a PHP project after deleting the contents of ugnt folder.
Log file:Fri Sep 16 2022.log.zip
Project: en_ulb_php_book.zip
Newer test instructions:
to test the upgrade delete the folder v0.22_Door43-Catalog
. Then rename the v0.29_Door43-Catalog
to v0_Door43-Catalog
On clean tCore startup you should see these bible versions in uhb:
v2.1.23_Door43-Catalog
. Then rename the v2.1.29_Door43-Catalog
to v0_Door43-Catalog
@elsylambert - have a new build translationCore 3.4.0 (279bc52) for testing. Also see the updated test steps above. ^^^
Works fine in translationCore 3.4.0 (7871560). Tested with a NT and an OT project. Seeing the alert to update to the version of the aligned resource for ugnt and uhb. Works as expected.
Story Explanation
User Story
Warn user when they try to open the wA tool with an older version of the ugnt than was last used. And direct the user to upgrade to that version.
This issue came from the field. alignments were being lost and work had to be redone. Made a fork of original repo https://git.door43.org/Mukesh_Parte/mr_mgst_jhn_book :
https://git.door43.org/tCore-test-data/mr_mgst_jhn_book Also made repos with snapshots of contents at specific upload dates:
Found another repo: https://git.door43.org/sunilkasbe/mr_mgst_jhn_book that I forked to:
Russ's recommendation on the fix:
Thanks for digging into this and figuring out what happened. I agree with Birch that something like:
But:
Features / Specifications
Definition of Done
Additional Context
Here is the timeline of git history: 7/20 - sachin_nerlekar started with tc 3.0.1 7/20 - sunilkasbe started with tc 3.0.1 and ugnt v0.14 7/21 - sunilkasbe updated to tC 3.2.0 and ugnt v0.24 working on tn, and a few wa fixes 7/28 - sunilkasbe updated to ugnt v0.26 7/28 - 7/29 - continued working on tn 7/29 - 8/3 - started working on tw 8/3 - 8/5 - continued working on tn 8/5 - sunilkasbe uploaded to D43 8/5 - Mukesh_Parte started working with tC 3.2.0 and ugnt v0.24 (this is going to an older version of ugnt) 8/5 - started doing word alignment starting with chapter 1 and making fixes to tw 8/23 - Mukesh_Parte uploaded to D43 8/24 - Mukesh_Parte uploaded to D43 <= problem reported on this date
Mockups