Percent complete is 99% for tW ru_rlob-2pe_book but it is all checked - Githubissues

unfoldingWord / translationCore

Repository for the desktop application translationCore

https://www.translationcore.com

Other

36 stars 11 forks source link

Percent complete is 99% for tW ru_rlob-2pe_book but it is all checked #7461

Open birchamp opened 1 year ago

birchamp commented 1 year ago

This project https://git.door43.org/ru_gl/ru_rlob_2pe_tcore_checked_tW-checked_tN-aligned shows 99% complete even though it is entirely checked.

birchamp commented 1 year ago

@elsylambert at some point when you're testing tC can you test this issue?

elsylambert commented 1 year ago

@birchamp Which tC version are you seeing this?

elsylambert commented 1 year ago

Tested this project in translationCore 3.4.0 (146a9f1) . After importing the project, tW shows 99% completion, when no GL was selected. After choosing English-en-D43 catalog as GL, the tools card shows 100% completion.

Screenshot 2022-12-07 at 9 48 36 AM

Download ru content, ru_gl, tW resources from content updater.
Select ru_gl as GL for tW card, the completion goes down to 99%.
Uncheck the "Key words" checkbox, the completion goes to 100%

elsylambert commented 1 year ago

Note that all the checks in tW are completed. @PhotoNomad0

PhotoNomad0 commented 1 year ago

@elsylambert How did you download this app? tCore is throwing an error for me that the url is not valid.

elsylambert commented 1 year ago

@PhotoNomad0 I did online import using the URL https://git.door43.org/ru_gl/ru_rlob_2pe_tcore_checked_tW-checked_tN-aligned last week.

PhotoNomad0 commented 1 year ago

@elsylambert Oops, I'm using QA server!

PhotoNomad0 commented 1 year ago

@elsylambert I'm wondering if this is because they have 4 tw checks that are marked as no selection is needed?

PhotoNomad0 commented 1 year ago

@elsylambert Yes, making selections for those four checks eventually gets to 100%. Will have to check the algorithm to see if makes use of no checks needed.

PhotoNomad0 commented 1 year ago

@elsylambert @birchamp - It looks like there is a check that is failing:

Screenshot 2022-12-12 at 12 07 19 PM

It looks like the groupId should have been "righteous" instead of "righteousness"? Not sure why it is not displayed though.

Here is the check in https://git.door43.org/ru_gl/ru_twl/src/branch/master/twl_2PE.tsv on line186. The path is rc://*/tw/dict/bible/kt/righteousness, but in https://git.door43.org/ru_gl/ru_tw/src/branch/master/bible/kt there is no article righteousness.md, but there is one for righteous.md. It's looking like a bug that tW is not showing the checks when the article is missing. Continuing to look...

PhotoNomad0 commented 1 year ago

Notes:

see generateMenuData() in ./tc-ui-toolkit/src/GroupedMenu/utils.js - it probably should handle entries from index (groupsIndex) whose id is not in data (groupsData). Or maybe tCore should create categories for check items not defined.