unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Add support for the new morph string format and keys (all handled in tc-ui-toolkit) #7468

Closed PhotoNomad0 closed 9 months ago

PhotoNomad0 commented 1 year ago

Notes:

  1. conversion of greek morph strings to human readable is handled in MorphUtils.getMorphLocalizationKeysGreek() in word-aligner which uses a tree (morphCodeLocalizationMapGrk) to interpret the fields
    • current morph strings are in format: "morph": "Gr,N,,,,,GMS," (13 characters)
    • new morph strings are like: "morph": "Gr,N,....NMS" (12 characters dropping the type)
    • in morphCodeLocalizationMapGrk it looks we
    • remove the type nested in role (2)
    • and all the fields from mood are decremented by 1 (e.g. mood goes from 4 to 3)
PhotoNomad0 commented 1 year ago

@elsylambert - latest build translationCore 3.4.1 (17ff357) has this update:

Test by enabling pre-release and then selecting for download:

Screenshot 2023-01-06 at 7 48 50 PM

and then for en:

Screenshot 2023-01-06 at 7 49 23 PM

Then open a Titus project (such as https://git.door43.org/unfoldingWord/en_ult/raw/branch/master/57-TIT.usfm) and for WA GL then en unfoldingWord

Screenshot 2023-01-06 at 7 59 12 PM

Launch WA and for 1:15 click on καθαρὰ (second word of verse) for both alignment area and in scripture pane the morph string should show:

Screenshot 2023-01-06 at 8 01 09 PM
elsylambert commented 1 year ago

Looks good and works as expected(as per the test instructions above^^) in translationCore 3.4.1 (5ed21f7) .

PhotoNomad0 commented 1 year ago

@elsylambert A new fix is in develop build translationCore 3.4.1 (f9a156c)

Testing fix for particle support:

Need to get latest pre-release of unfoldingword ugnt.

open a 1 Cor project . Scroll down to WA tool and select unfoldingword en as gateway language launch wa and in 1:13, should see:

Screenshot 2023-02-01 at 2 42 56 PM

elsylambert commented 1 year ago

Looks good in translationCore 3.5.0 (84d05fd).

Screenshot 2023-02-03 at 8 56 33 AM