search

unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Highlighting broken with Ampersand in tNotes original quotes #7490

Open PhotoNomad0 opened 1 year ago

PhotoNomad0 commented 1 year ago

Story Explanation

User Story

Highlighting broken with Ampersand in tNotes original quotes when there is a verse span.

@abelpz found this while testing a verse range combined with an original language quote that contained an ampersand.

To see this in tCore, download the pre-release of en_ult and en_tn in es-419_lab org. Open a php project in tCore. And for tNotes select the GL of es-419_lab/en_tn. Launch tNotes and look in abstract-nouns. The highlighting is greedy:

Screenshot 2023-03-27 at 6 47 54 AM

Features / Specifications

Definition of Done

Additional Context

Mockups

PhotoNomad0 commented 1 year ago

@birchamp @elsylambert - The first step here is to do a refactor: https://github.com/unfoldingWord/translationCore/issues/7492. Later we can use the shared code in all the apps so we have consistent highlighting. And then we can fix this greedy highlighting behavior in all apps at the same time.