Export with alignments fails in tCore which also breaks upload

unfoldingWord / translationCore

Repository for the desktop application translationCore

https://www.translationcore.com

Other

36 stars 11 forks source link

Export with alignments fails in tCore which also breaks upload #7511

Closed PhotoNomad0 closed 8 months ago

PhotoNomad0 commented 1 year ago

Story Explanation

User Story

Export with alignments fails in tCore which also breaks upload. It also affects uploading to D43 (which also exports to USFM before upload). Seems to be related to verse spans. Perhaps those that were partially aligned before verse span alignment was added.

To reproduce try exporting this project:

https://app.zenhub.com/files/65028237/981a55a4-86ab-4300-b4ee-df431be93290/download

Features / Specifications

Definition of Done

Additional Context

Mockups

PhotoNomad0 commented 1 year ago

@elsylambert @danielklapp - The fix is in translationCore 3.5.0 (30831db).

When testing with the above project - if before opening the project, you export to USFM with alignments. Then you will now see a warning that alignments have been invalidated. If you click on export. Then will see that alignments being updated for Num 5:12, 5:13, and 5:20. And then will get the file dialog to select where to save the file.

PhotoNomad0 commented 1 year ago

Note:

the exceptions thrown in old tC versions are related to the empty verses in ch 5 - 12,13,20,21

elsylambert commented 12 months ago

@PhotoNomad0 Testing in translationCore 3.5.0 (30831db) with the above mentioned steps and the above project. When exported to USFM with alignments., before opening the project, saw a warning that alignments have been invalidated>clicked on export and then saw that alignments were updated for Num 5:12, 5:13, and 5:20. After that I got the file dialog to select where to save the file.