search

unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Bengali Galatians doesn't show correctly in PDF preview. #7533

Closed birchamp closed 3 months ago

birchamp commented 11 months ago

If you import the attached USFM and choose print preview then the preview shows that chapter 1 beginning at verse 6. The first paragraph marker \p is just before verse 6. Other USFM texts with no paragraph markers work correctly. 49-BN_GAL file

screenshot

PhotoNomad0 commented 11 months ago

Will likely need to upgrade to latest proskomma print. Sent from my iPhoneOn Oct 10, 2023, at 3:41 AM, birchamp @.***> wrote: If you import the attached USFM and choose print preview then the preview shows that chapter 1 beginning at verse 6. The first paragraph marker \p is just before verse 6. Other USFM texts with no paragraph markers work correctly. 49-BN_GAL.usfm.txt Private Zenhub Image

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

birchamp commented 11 months ago

Thanks @PhotoNomad0 Is it using proskomma already?

PhotoNomad0 commented 11 months ago

Yes, but it was a year old library. They have done major refactoring and the API has changed.  So I expect significant rework integrating that into tC.  Or we could do a quick hack to insert a paragraph marker at beginning in print queue if needed. Sent from my iPhoneOn Oct 10, 2023, at 5:00 AM, birchamp @.***> wrote: Thanks @PhotoNomad0 Is it using proskomma already?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

PhotoNomad0 commented 11 months ago

@birchamp @elsylambert - tested with latest release: translationCore 3.5.1 (6e1cd7b). This is looking good here, but then again the example file above does have a \p after chapter 1.

Screenshot 2023-10-11 at 11 57 20 AM
PhotoNomad0 commented 11 months ago

@birchamp @elsylambert OK, I removed the first \p marker and see the bug mentioned.

It looks like last year we made a fix for bibles that did not have any paragraph markers (do not understand proskommas fixation about paragraph markers). Now adding a fix for when there is not a paragraph marker before the first verse.

Do we want to release a minor tCore update with this fix?

PhotoNomad0 commented 11 months ago

@elsylambert Fix is in latest develop build translationCore 3.5.2 (9d8cdec)

elsylambert commented 6 months ago

Looks good in translationCore 3.6.4 (ee24062).

Screenshot 2024-03-21 at 9 01 43 AM