unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

TranslationAcademy pane shows RTL languages left aligned when expanded #7562

Closed elsylambert closed 2 weeks ago

elsylambert commented 4 months ago

Project: ar_new_phm_book.zip Open an Arabic project and go to tW. Screenshot:

Screenshot 2024-03-04 at 12.44.55 PM.png
PhotoNomad0 commented 3 months ago

@elsylambert This screenshot seems broken?

elsylambert commented 3 months ago
Screenshot 2024-03-19 at 11 24 07 AM
PhotoNomad0 commented 3 months ago

@elsylambert Does this look right to you:

Screenshot 2024-03-19 at 1 18 52 PM

And also the side panel is backwards also:

Screenshot 2024-03-19 at 12 53 08 PM
elsylambert commented 3 months ago

@PhotoNomad0 The screenshot above ^^ is Hindi which is actually LTR, so it looks odd to me, but otherwise by RTL perspective, it is fine . May be I can try with Arabic TA.

PhotoNomad0 commented 3 months ago

Yeah, my goof here on language selection. Still working on the implementation to use language direction of GL.

PhotoNomad0 commented 3 months ago

@elsylambert Here's a second attempt with Farsi as the GL:

Screenshot 2024-03-19 at 2 29 50 PM
elsylambert commented 3 months ago

Looks good to me.

On Tue, Mar 19, 2024 at 2:31 PM Bruce McLean @.***> wrote:

@elsylambert https://github.com/elsylambert Here's a second attempt with Farsi as the GL: Screenshot.2024-03-19.at.2.29.50.PM.png (view on web) https://github.com/unfoldingWord/translationCore/assets/14238574/852e336e-434a-412f-885b-7b6acba8427f

— Reply to this email directly, view it on GitHub https://github.com/unfoldingWord/translationCore/issues/7562#issuecomment-2007868070, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMLH7ZEUFIOY2N52NNQB3CLYZCABBAVCNFSM6AAAAABEFUPSPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXHA3DQMBXGA . You are receiving this because you were mentioned.Message ID: @.***>

PhotoNomad0 commented 3 months ago

@elsylambert Fix is in latest develop build translationCore 3.6.4 (ee24062)

elsylambert commented 3 months ago

Looks good in translationCore 3.6.4 (ee24062). TA pane and the expanded tA article are now RTL Compatible.

Screenshot 2024-03-20 at 9 25 20 AM