search

unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Get latest resources from Door43-Catalog broken for en #7588

Open PhotoNomad0 opened 1 month ago

PhotoNomad0 commented 1 month ago

Story Explanation

User Story

Definition of Done

Additional Context

Mockups

PhotoNomad0 commented 1 month ago

Fix is in release-v3.6.6

Not ready yet.

PhotoNomad0 commented 1 month ago

To test, start tcore. After it opens click get started. delete the Door43-Catalog English resources from the translationCore/resources/en folder: delete these folders~/translationCore/resources/en/bibles/ult, ~/translationCore/resources/en/bibles/ust, ~/translationCore/resources/en/translationHelps. "Now do actions/check for content update". Under en, should see the Door43-Catalog content listed:

Screenshot 2024-09-04 at 6 32 10 AM

The fix is if the query returns the master branch as the latest, we look in the source repo in unfoldingWord org to get the latest released version number.

PhotoNomad0 commented 1 month ago

Note:

still not right, trying again...

PhotoNomad0 commented 1 month ago

@elsylambert Latest fix is in translationCore release-3.6.6 (898ab1e) see testing notes above ^^^

Also need a way to test loading of missing original language version dependencies.

Also make sure you can open psalms projects in checking tool with en Door43-Catalog selected.

elsylambert commented 3 weeks ago

@PhotoNomad0 Testing in translationCore 3.6.6 (d22e4d4). The content updater does not show Door43 Catalog resources, Nor the unfoldingWord org resources.

Screenshot 2024-09-09 at 2 17 04 PM

But the resources folder contains the ULT and UST and also translationHelps folder.

Screenshot 2024-09-09 at 2 17 57 PM
PhotoNomad0 commented 3 weeks ago

@elsylambert Are you sure you deleted the folders after you started tCore? If you delete them before you start tCore, they will be automatically recreated on startup. And the latest versions are already bundled in tCore.

elsylambert commented 3 weeks ago

@PhotoNomad0 Thanks for clarifying that. Yes, I am able to see the resources in the content updater, when I delete the folders after restarting tC. So Technically, since en resources from D43 catalog and uW org are bundled with tC, they are available when tC is started.

elsylambert commented 3 weeks ago

Testing #7121 for this change

elsylambert commented 3 weeks ago

I deleted the contents of el-x-koine under resources folder after restarting tC and tried to open a NT project and got the following warning.

Screenshot 2024-09-10 at 9 42 01 AM

This works as expected. I did the same for two different projects that used two different versions and both the version got downloaded in the ugnt folder.

Screenshot 2024-09-10 at 9 42 21 AM

Again, these folders are bundled when tC is restarted so not getting the prompt untill I delete the contents of the ugnt folder.

elsylambert commented 3 weeks ago

Testing with Arabic GL. I deleted Ar resources from the Resource folder and tried to download from the content updator and it showed failed.

Screenshot 2024-09-13 at 11 00 43 AM
PhotoNomad0 commented 3 weeks ago

Testing with Arabic GL. I deleted Ar resources from the Resource folder and tried to download from the content updator and it showed failed. Screenshot 2024-09-13 at 11 00 43 AM

Very interesting - it is trying to download from BSOJ org. Good catch. I'm guessing that you selected ar resources from BSOJ?

PhotoNomad0 commented 3 weeks ago

@elsylambert I see from the console log that this failure came after you opened an Arabic project. I presume you were prompted to download the correct original language resource, and that is where it failed?

PhotoNomad0 commented 3 weeks ago

@elsylambert I tried deleting the ugnt, and then opening an ar project, but it didn't fail for me when it downloaded the original language.

Could you give more detail on how to reproduce this?

And maybe the console log file.

elsylambert commented 3 weeks ago

Are you downloading the BSOJ avd resources? I was downloading the Arabic bible resources.

On Sat, Sep 14, 2024 at 8:35 AM Bruce McLean @.***> wrote:

@elsylambert https://github.com/elsylambert I tried deleting the ugnt, and then opening an ar project, but it didn't fail for me when it downloaded the original language.

Could you give more detail on how to reproduce this?

— Reply to this email directly, view it on GitHub https://github.com/unfoldingWord/translationCore/issues/7588#issuecomment-2350975731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMLH7ZGTCB6POY6FBTGOUCLZWQURJAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TKNZTGE . You are receiving this because you were mentioned.Message ID: @.***>

PhotoNomad0 commented 3 weeks ago

Are you downloading the BSOJ avd resources? I was downloading the Arabic bible resources. … On Sat, Sep 14, 2024 at 8:35 AM Bruce McLean @.> wrote: @elsylambert https://github.com/elsylambert I tried deleting the ugnt, and then opening an ar project, but it didn't fail for me when it downloaded the original language. Could you give more detail on how to reproduce this? — Reply to this email directly, view it on GitHub <#7588 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMLH7ZGTCB6POY6FBTGOUCLZWQURJAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TKNZTGE . You are receiving this because you were mentioned.Message ID: @.>

I tried three different ways - all ar resources, BSOJ resources and finally I just tried the AVD. Here are the options I see:

Screenshot 2024-09-14 at 9 36 07 AM

But not reproducing the problem.

elsylambert commented 3 weeks ago

Thanks Bruce, I’m away from my computer now. I will try to replicate again and send my log file as well.

On Sat, Sep 14, 2024 at 9:41 AM Bruce McLean @.***> wrote:

Are you downloading the BSOJ avd resources? I was downloading the Arabic bible resources. … <#m-5489818895582511330> On Sat, Sep 14, 2024 at 8:35 AM Bruce McLean @.> wrote: @elsylambert https://github.com/elsylambert https://github.com/elsylambert https://github.com/elsylambert I tried deleting the ugnt, and then opening an ar project, but it didn't fail for me when it downloaded the original language. Could you give more detail on how to reproduce this? — Reply to this email directly, view it on GitHub <#7588 (comment) https://github.com/unfoldingWord/translationCore/issues/7588#issuecomment-2350975731>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMLH7ZGTCB6POY6FBTGOUCLZWQURJAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TKNZTGE https://github.com/notifications/unsubscribe-auth/AMLH7ZGTCB6POY6FBTGOUCLZWQURJAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TKNZTGE . You are receiving this because you were mentioned.Message ID: @.>

I tried three different ways - all ar resources, BSOJ resources and finally I just tried the AVD. Here are the options I see: Screenshot.2024-09-14.at.9.36.07.AM.png (view on web) https://github.com/user-attachments/assets/c644924b-52cd-4aab-a953-bd788c1cb536

But not reproducing the problem.

— Reply to this email directly, view it on GitHub https://github.com/unfoldingWord/translationCore/issues/7588#issuecomment-2350995710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMLH7ZGBL6BP3QFINNJWTNDZWQ4HRAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE4TKNZRGA . You are receiving this because you were mentioned.Message ID: @.***>

PhotoNomad0 commented 3 weeks ago

@elsylambert Maybe something specific to that project. Where can I get it?

PhotoNomad0 commented 3 weeks ago

Testing with translationCore 3.6.6 (d22e4d4)

elsylambert commented 3 weeks ago

Arabic resources on my local: ar.zip Project: ar_test_phm_book.zip Log file: Fri Sep 13 2024.log.zip

PhotoNomad0 commented 3 weeks ago

Arabic resources on my local: ar.zip Project: ar_test_phm_book.zip Log file: Fri Sep 13 2024.log.zip

Thanks Elsy - the log file helped me find the logic error that it was trying to download the original language from the BSOJ org.

PhotoNomad0 commented 3 weeks ago

@elsylambert Thanks for the log file - it helped identify the problem. It looks like the project had BSOJ/ar selected as the GL for the wordAlignment tool, so when the project was opened it was looking to download the ugnt from the same owner. I found the logic error and made a fix in the latest release build. It should fix the latest problem.

PhotoNomad0 commented 3 weeks ago

@elsylambert Looks like I'll have to try again, since that fix uncovered another bug.

PhotoNomad0 commented 2 weeks ago

@elsylambert After looking into it further, I only saw a crash because I had deleted all the ugnt versions while app was open - not a typical user scenario. So when you get a chance, go ahead and test the latest release build (635b02f) to see if it works for you.

elsylambert commented 2 weeks ago

Verified in translationCore 3.6.6 (635b02f). Not seeing error with Arabic GL resources download.