Closed ReneSkukies closed 1 month ago
@behinger if you let me know what you prefer, I can make a pull request ๐๐ผ
ah thanks for catching. Indeed, I think I like the convenience function to wrap a single string input into a predictor like in exclude_basis
if you want to implement: ๐
Working on it on the update_predict branch ๐๐ผ
Currently, there is an inconsistency in the input of the
predict()
function when using thekeep_basis
andexclude_basis
keywords:I think this should either be consistent or made apparent to the user.
The error results from the
matrix_by_basisname(::AbstractMatrix, ::Any, !Matched::Vector)
only accepting a vector as input.I think the easiest solution would be to force the user to use a vector from the start and provide useful error messages. The other option would be to convert to a vector. Either way this should also be made apparent in the docstring of
predict()