Implement tests & Doc fixes

unfoldtoolbox / UnfoldBIDS.jl

MIT License

5 stars 2 forks source link

Implement tests & Doc fixes #84

Closed ReneSkukies closed 3 weeks ago

ReneSkukies commented 1 month ago

Implements some tests and fixes the documentation a bit

@behinger can you review?

behinger commented 1 month ago

I have not looked at the tests yet & havent checked the documention.

The docs preview is not yet rendered on github right? at least https://unfoldtoolbox.github.io/UnfoldBIDS.jl/previews/PR84 this doesnt exist. We do that in UnfoldSim, UnfoldMakie and maybe others. have a look at their docs/make.jl & the last command therein

ReneSkukies commented 1 month ago

Everything should be addressed now

Haven't tried the docs preview yet, though.

behinger commented 1 month ago

https://unfoldtoolbox.github.io/UnfoldBIDS.jl/previews/PR84/

you write that you still have to load the events to data_df - maybe provide code how to do that?
Maybe it would be helpful to see first(data_df,2) or something

I like it! It is right now a small package, but can grow to something super useful. well done :)