unfoldtoolbox / UnfoldMakie.jl

Plotting and visualization tools for EEG data, with additional Unfold.jl regression ERP methods. Based on the visualization libraries Makie.jl and AlgebraOfGraphics.jl
https://unfoldtoolbox.github.io/UnfoldMakie.jl/
MIT License
16 stars 7 forks source link

topoplot interpretation label #129

Closed vladdez closed 4 months ago

vladdez commented 10 months ago

We asked in a survey about time interpretation on topoplot and topoplot timeseries´, but don't have any ways to put that on a plot yet. Should be added.

behinger commented 10 months ago

these labels already exist grafik

squrae => timepoint included, round timepoint excluded, according to the accepted notation for ranges

Did you have something else in mind?

vladdez commented 10 months ago

Hm, OK, but do we have a way of switching between the modes? There should be two modes: time point or average of time interval. Ideally it should be done by an argument.

behinger commented 10 months ago

mh that feature is not yet implemented. it is very easy to implement though. You could just use the following combinefun :

eeg_topoplotseries(...,combinefun = x->x[end÷2])

it needs a dedicated argument though, because this is a bit opaque ;-) What it does is instead of averaging (mean is default) it selects the middle element (if this is what one wants to specfy, and not the first sample) - what needs fixing further is the labels

vladdez commented 10 months ago

selects the middle element - is it the median?

will eeg_topoplotseries(...,combinefun = median) five the same result?

vladdez commented 10 months ago

and of course it should show one number, not the interval

vladdez commented 10 months ago

also we need such option of a single topoplot.

behinger commented 10 months ago
vladdez commented 10 months ago
  1. I tried and see no difference visually (and theoretically tbh)
  2. ok
  3. for sake of reproducibility! looking at a single topoplot I want to know what it shows me: a single time point (and which one exactly), mean over all time points (or some time interval), what is the time interval used (sec or msec)? If we are advocating for label specification everywhere we should be strict ourselves.
behinger commented 10 months ago

between median, mean and selecting the middle value?

  1. I cant think of a good interface, what exactly do you propose?
vladdez commented 10 months ago

basically the same as in a topoplot series: a title with a single number or time interval under the topoplot

vladdez commented 10 months ago

image

behinger commented 10 months ago
  1. no, the result is clear, but the interface, how you call plot_topoplot differently.
  2. for mean, median and middle value the result might look similar in smooth data, but it is extremely unlikely that they are the same
vladdez commented 10 months ago
  1. why should we call it differently? I think it should be default feature. How to implement it? That why I am asking you ^^
  2. the difference between mean and median is clear. The difference between median and middle is not clear, they are synonyms, isn't it? Like "the median is the middle value when a data set is ordered from least to greatest".
behinger commented 10 months ago
  1. missunderstanding, how should we call the plot_topoplot signature differently, e.g. also offer combinefun?
  2. exactly, the median is fo the sorted/ordered vector, which is not the case for choosing the midlevalue (a single sample)
vladdez commented 10 months ago
  1. actually that is a hard question. A partial solution could be just to enable opportunity to manually specify xlabel.
  2. okay