search

unfoldtoolbox / UnfoldMakie.jl

Plotting tools for Unfold.jl based on Makie.jl and AlgebraOfGraphics.jl
MIT License
15 stars 7 forks source link

plot_erp: Multi-Panel Plotting broken #149

Closed behinger closed 4 months ago

behinger commented 4 months ago

I just noticed that multi-panel plotting is broken

e.g. mapping = (;col=:group) should result in multiple subplots, but it doesnt

For me that was the main motivation to use AlgebraOfGraphics in the first place ;-)

I think the offending lines are these:

        # draw a normal ERP lineplot 
        mainAxis = Axis(
            f_grid;
            config.axis...,
            xlabel = config.axis.xlabel,
            ylabel = config.axis.ylabel,
            yticklabelsize = config.axis.yticklabelsize,
        )
        drawing = draw!(mainAxis, plotEquation;)

Two things spring to mind, the xlabel=,ylabel=,yticklabelsize= lines can simply be removed, but are not cause of the error.

Pulling up a PR to fix this

behinger commented 4 months ago

fixed in #149 - unittests I havent checked yet