unfoldtoolbox / UnfoldMakie.jl

Plotting tools for Unfold.jl based on Makie.jl and AlgebraOfGraphics.jl
MIT License
15 stars 7 forks source link

Topoplotseries #186

Closed vladdez closed 2 days ago

vladdez commented 2 weeks ago
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 98.78049% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.63%. Comparing base (5f24e32) to head (0c5d556). Report is 16 commits behind head on main.

:exclamation: Current head 0c5d556 differs from pull request most recent head 277c241

Please upload reports for the commit 277c241 to get more accurate results.

Files Patch % Lines
src/plot_topoplotseries.jl 97.61% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #186 +/- ## ========================================== + Coverage 87.14% 87.63% +0.48% ========================================== Files 18 18 Lines 856 849 -7 ========================================== - Hits 746 744 -2 + Misses 110 105 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vladdez commented 1 week ago

The level of change is huge, while faceting is still far away Maybe accept this part? and think on faceting in next PR?

behinger commented 3 days ago

nice! only some small comments