unfoldtoolbox / UnfoldMakie.jl

Plotting tools for Unfold.jl based on Makie.jl and AlgebraOfGraphics.jl
MIT License
15 stars 7 forks source link

allow abstractvector in plot_topoplot #193

Closed behinger closed 3 days ago

vladdez commented 1 week ago

Could you write down a context and benefits of this PR? Maybe add some checking test?

behinger commented 1 week ago

right now topoplot(zeros(1:128) doesnt work because it is Float64

Something like a view(dataframe[1:10,1:10]) will also not work

vladdez commented 1 week ago

I created two tests and they both are failing Could you check them

behinger commented 1 week ago

maybe specify some random positions?

vladdez commented 1 week ago

I though any function can work without kwargs

vladdez commented 1 week ago

I looked in the code In current implementation any vector should have column names View() and zeroes() will not give column names

behinger commented 1 week ago

how would topoplot work without positions?

behinger commented 1 week ago

yeah you have to wrap it with a eeg_matrix_to_dataframe - I thought you had implemented that by default - sorry

vladdez commented 3 days ago

Done: