Adapt simulate function to return a data matrix instead of a concatenated vector for multiple subjects

unfoldtoolbox / UnfoldSim.jl

Simulate EEG / ERP data with overlap, non-linear effects, multiple regression

MIT License

7 stars 4 forks source link

Adapt simulate function to return a data matrix instead of a concatenated vector for multiple subjects #47

Closed jschepers closed 10 months ago

jschepers commented 10 months ago

I deleted obsolete code from the convert function + added todo to move it to Unfold.jl
I adapted the simulate function such that the data is returned as a matrix instead of a concatenated vector (i.e. the convert function is not used anymore)
I wrote four testsets for the simulate function (single vs. multi-subject, single vs. multi-channel)
- So far, I only tested the type and size of the returned data variable. Maybe you have ideas for more tests or we add them later.
- I hope these tests are a good fit for test/simulation.jl. Otherwise, I can of course move them to another file.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (17a5069) 26.43% compared to head (b8043ee) 69.74%. Report is 17 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #47 +/- ## =========================================== + Coverage 26.43% 69.74% +43.31% =========================================== Files 10 10 Lines 314 314 =========================================== + Hits 83 219 +136 + Misses 231 95 -136 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

behinger commented 10 months ago

ah wait - Docs are failling, after we fix that? - rerunning docs if something in main changed to fix it

jschepers commented 10 months ago

ah wait - Docs are failling, after we fix that? - rerunning docs if something in main changed to fix it

Did you have a look at what's failing in docs or shall I have a look? :)

behinger commented 10 months ago

ah wait - Docs are failling, after we fix that? - rerunning docs if something in main changed to fix it

Did you have a look at what's failing in docs or shall I have a look? :)

still rerunning - but if it fails in 15min, maybe you can have a look, I'm still at the SFB thingy

behinger commented 10 months ago

still failing. can you have a look?