unfunco / terraform-aws-oidc-github

Terraform module to configure GitHub Actions as an IAM OIDC identity provider in AWS.
https://registry.terraform.io/modules/unfunco/oidc-github/aws/latest
Apache License 2.0
91 stars 51 forks source link

fix: typing on tags should be map not object #3

Closed henworth closed 2 years ago

henworth commented 2 years ago

This changes the typing declaration on var.tags to ensure tags can be properly passed in. When defined as object({}) the input tag contents seem to be ignored as is evident by this truncated plan:

  # aws_iam_openid_connect_provider.github[0] will be created
  + resource "aws_iam_openid_connect_provider" "github" {
      + arn             = (known after apply)
      + client_id_list  = [
          + "https://github.com/REDACTED",
          + "sts.amazonaws.com",
        ]
      + id              = (known after apply)
      + tags_all        = (known after apply)
      + thumbprint_list = [
          + "6938fd4d98bab03faadb97b34396831e3780aea1",
        ]
      + url             = "https://token.actions.githubusercontent.com"
    }

When changed there as in this PR, there is a tag attribute with the expected contents.

unfunco commented 2 years ago

Thank you for this, I noticed the tags were missing a week or two ago but hadn't looked into it yet, I'll sort a couple of other bits out and will release a new version this evening.

unfunco commented 2 years ago

I've tagged v0.4.1 which includes your fix, thanks again!