search

ungap / custom-elements

All inclusive customElements polyfill for every browser
ISC License
240 stars 14 forks source link

When Element is not of type HTML it was crashing #10

Closed bapu closed 2 years ago

WebReflection commented 2 years ago

In which circumstances this fails? I need to see a test case, an issue, a code to reproduce, and then move all of this into the right repository which is not this one.

Thanks.

WebReflection commented 2 years ago

@bapu OK, I think I've seen where was the issue. The current change filters by ^HTML.*Element$ instead, which are all classes.

bapu commented 2 years ago

Thank you On Thu, Mar 10, 2022 at 4:52 AM Andrea Giammarchi @.***> wrote:

@bapu https://github.com/bapu OK, I think I've seen where was the issue. The current change filters by ^HTML.*Element$ instead, which are all classes.

— Reply to this email directly, view it on GitHub https://github.com/ungap/custom-elements/pull/10#issuecomment-1063866401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGCGIBWCXSF3BWPTAW6OSLU7HA6HANCNFSM5QLNIMMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>