Improved code size and performance: one shot - Githubissues

ungap / raw-json

JSON.rawJSON and isRawJSON ponyfill

MIT License

24 stars 0 forks source link

Improved code size and performance: one shot #1

Closed WebReflection closed 2 weeks ago

WebReflection commented 2 weeks ago

The goal of this MR is to reduce code size down to 90 LOC and improve performance:

single RegExp VS (previously) 3 parses + array access
ignored keys while keep parsing safely (all strings matched)
reduced memory usage on parse
removed array push via terser still explicit code

Also tests VS native (Node) are there for comparison: a win-win all over the place? 🥳

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 11270638178

Details

15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 11269950490:	0.0%
Covered Lines:	90
Relevant Lines:	90

💛 - Coveralls