ungerik
commented
9 years ago Using an array is very descriptive for the function interface, but I guess passing a slice would be more efficient since it's only a reference and doesn't copy 64 bytes. I would rather change the go-gl interface.
I could implement mat4.T as float array, but then we would miss out on the handy feature of it being an array of 4 vectors.
So let's compromise on adding a mat4.T.Array() [16]float32 method. Send me a pull request for it.
-Erik
On Mon, Aug 25, 2014 at 10:29 PM, Christian Haas notifications@github.com wrote:
The methods T.Slice() returns a slice to access the single fields, but this is incompatible with functions such as from go-gl on the UniformLocation type to specify some matrix values. Theses methods have arrays in their signature:
func (location UniformLocation) UniformMatrix4fv(transpose bool, list ...[16]float32) {
as seen here https://github.com/go-gl/gl/blob/2cf494e17e96fdd93743d8c16637f1261aafda82/uniformlocation.go#L132
There is already one copy operation per field going on, I'd like to avoid having a second operation to copy the slice to a compatible array. Hence I'd like to propose the feature to add T.Array(), such as mat4.Array() [16]float32.
Do you see this as a suitable addition to the library? Would you want to do this on your own or via pull request?
— Reply to this email directly or view it on GitHub https://github.com/ungerik/go3d/issues/7.
+43 650 58 33055 erik@erikunger.com Skype: ungerik http://erikunger.com http://github.com/ungerik http://twitter.com/ungerik http://facebook.com/ungerik http://www.linkedin.com/in/ungerik http://www.xing.com/profile/Erik_Unger2
alexozer
dertseha
The methods T.Slice() returns a slice to access the single fields, but this is incompatible with functions such as from go-gl on the UniformLocation type to specify some matrix values. Theses methods have arrays in their signature:
as seen here
There is already one copy operation per field going on, I'd like to avoid having a second operation to copy the slice to a compatible array. Hence I'd like to propose the feature to add T.Array(), such as
mat4.Array() [16]float32.Do you see this as a suitable addition to the library? Would you want to do this on your own or via pull request?