Settings window

[PapitaConPure]

Is there an existing issue for this?

• [X] I have searched the existing issues

Describe the problem

It's a bit tedious to work with a popup menu that you need to show again for each setting you want to change.

Solution

I think it'd be a good idea to make the "Settings" option within the menu show a window rather than a sub-popup menu. (I don't know if this isn't possible due to technicalities, but I checked the issues and found nothing related. Correct me if I'm wrong)

Here's a fast sketch of how it could roughly look like in Windows:

Something similar should be achievable in Linux and MacOS.

Also, regarding #42, something like this could be implemented on the appearance tab:

Alternatives

No response

Additional context

No response

[ungive]

That sketch looks amazing!

I definitely agree with your points, I will move away from putting everything in the tray menu at some point, but I intended to keep it this way for as long as it's "good enough" and focus on adding features. I will definitely come back to this though!

Thanks for putting the effort into making these images, it'll be a very good reference for when I come around to designing the menu.

[ungive]

One thing, on Windows the tray menu should stay opened when you click checkboxes. I've added that in a recent update. Does that not work for you?

[PapitaConPure]

I remember playing with the settings yesterday and having to click the tray icon each time. It might be my memory playing tricks on me though, so I'll confirm it when I'm home

[ungive]

I introduced that change in version 2.2.0

https://github.com/ungive/discord-music-presence/blob/master/CHANGELOG.md

2.2.0 Tray menu improvements When clicking a checkbox, the tray menu is not closed anymore. That way it should be easier to change multiple settings in one go instead of having to reopen the menu every time after changing a setting.

But you probably have that installed, otherwise you probably wouldn't have the new settings added to your sketch.

The same code that introduced that change doesn't work on Mac though (it's using the Qt UI library), so I wouldn't be surprised if it doesn't work for some Windows users either for whatever reason. Qt's theme detection also doesn't work for me, but I was sure it worked before. It seems so random at times.

[PapitaConPure]

I can confirm it's working. I just misremembered it still closing after each change, my bad.

Regarding the theme detection if it helps at all, here's how it looks on my machine. I think it's working properly but those section labels look a bit weird

[ungive]

Thanks for confirming. Yeah, that's the way "disabled" labels look, I could tweak that a bit, I suppose.

[PapitaConPure]

Well, if it's working fine I'd say this is pretty low-priority then, good job. I'll be patiently looking forward to more!

[ungive]

I will close this issue until the need for an improved UI arises. Thanks for opening it!

[ungive]

Reopening this, as this will be needed for #42 and #62