ungive / discord-music-presence

The Discord music status that works with any media player
https://musicpresence.app
Other
229 stars 2 forks source link

Opt-out setting for showing logo of media or streaming service in status #46

Closed Plaged closed 1 month ago

Plaged commented 1 month ago

Is there an existing issue for this?

Describe the problem

The feature "Shows the logo of the media player or streaming service that is playing your music in your status" cannot be opt-out, being forced to have the logo of the media player next to the album cover, which can be redundant when you're already displaying the name of the player in your "Listening to ..." RPC

Solution

A new setting, if possible, to allow users to choose whether they want to display the media player logo or not

Alternatives

No response

Additional context

It'd be perfect to mimic the Spotify look even more

ungive commented 1 month ago

Hey, I can definitely see the appeal in adding an option to hide the logo of the streaming service and I would love to just add it, but there is a few issues with that, mostly legal ones but also a technical issue.

I'd like to be very thorough in my answer to give you insight into my thinking and also provide a resource for people that want to suggest the same thing in the future (I'm sure there will be quite a few).

You can already hide the player logo of offline players, but for streaming services I didn't add such an option yet for the following reasons:

I hope those reasons make sense to you and showing that logo is a small price to pay for an unparalleled Discord status.

I'd love to hear your thoughts too and if that brand icon is a dealbreaker for you and for what reasons. Personally, I'm not bothered by it at all, so I'm curious about your thoughts.

Kind regards!


Quotes from the TIDAL Developer Terms:

TIDAL Developer Terms of Service III - Use of TIDAL Marks To the extent we make available any TIDAL logos, trademarks, or other identifiers ("TIDAL Marks") for your use in connection with Your Offering, you will use them in accordance with the TIDAL Developer Design Guidelines.

TIDAL Developer Design Guidelines Attribution TIDAL content is owned by a variety of independent rights owners. By using TIDAL metadata (including artist, album and track names, album/artist artwork, and audio playback), you agree to always show any content alongside the TIDAL brand."

Additional resources:


PS:

What I also find "nice" about enforcing the brand in the status is that it's a good reminder that you are using a service and you don't "own" the music, as in, you haven't bought a copy and you're only allowed to listen to it for a limited time while paying a monthly fee. I encourage anyone to buy CDs from artists directly and listen to them with an offline media player, that's the best way to support their work. :)

But that is just my opinion and not a deciding factor.

Plaged commented 1 month ago

That's very interesting, thanks for sharing and being informative! I can definitely understand on how this can be an issue, personally the branding next to album cover doesn't bother me either, I was just suggesting as i thought it was an oversight, personally i'd have it disabled just to make it more similar to Spotify integration and show more of the album cover, but even the Spotify integration have a small spotify logo which is something developers currently can't do. I was thinking perhaps hiding the logo could be done if the user allows the RPC to display as Listening to Tidal instead of Listening to Music, thus at least from my understanding it would be with TIDAL's conditions. Nonetheless amazing app

ungive commented 1 month ago

but even the Spotify integration have a small spotify logo which is something developers currently can't do.

Yeah, that's unfortunate, but maybe that will change in the future!

I was thinking perhaps hiding the logo could be done if the user allows the RPC to display as Listening to Tidal instead of Listening to Music, thus at least from my understanding it would be with TIDAL's conditions.

You're right, that might be enough in TIDAL's case. If I were to use the Spotify API I'd definitely have to show the logo though ("To comply with our licensing agreements, you must always attribute content from Spotify with the logo."). The legal side of things is complicated and it's different with every service, I'd probably have to undo a setting like "Hide the logo when you show the player name instead of Music" in the future when I wanna use an API that requires me to show the logo/icon.

Nonetheless amazing app

Thanks! Feel free to recommend it :)

Closing this as I'm not planning on adding an option to hide service logos anytime soon.