search

ungive / discord-music-presence

The Discord music status that works with any media player
https://musicpresence.app
Other
229 stars 2 forks source link

Winamp 5.9.2 on Windows 10 Pro not detected #54

Closed hans-juergen closed 1 month ago

hans-juergen commented 1 month ago

I am playing local music files with the latest official Winamp version on my Windows 10 Pro computer, but Music Presence does not detect that Winamp is running, it only shows the Deezer desktop being active. Disabling Deezer does not change this. Is it because Winamp can also show videos perhaps and so gets blocked? I never use it for showing video files, by the way, I use the default Windows app for that.

ungive commented 1 month ago

Did you install Winamp using the WACUP installer? I should maybe clarify in the players documentation that vanilla Winamp does not report what it is playing to Windows.

Try running this and see if Winamp shows up while playing media with Winamp: https://github.com/ungive/media-session-dump

On the releases page you can find msd.exe which dumps all media that is detected on your device. If your Winamp doesnt show up, it's not reporting anything.

hans-juergen commented 1 month ago

On this computer I have installed the "original" Winamp from the new owners that have released the source code in September, by the way. WACUP is installed on another computer with Windows 10 Pro as well, but there is no mixup between those two. I also read today that WACUP has its own Discord implementation and disables the existing Winamp plugin from another developer, as it causes problems. I think it is this old one which is not maintained anymore: https://github.com/clandrew/wdrp

msd.exe will show nothing when Winamp 5.9.2 is running alone, only from Deezer and Spotify while their desktop apps are paused.

ungive commented 1 month ago

Yeah, the "original" Winamp doesn't report any media information. WACUP should report it though! And the Winamp version that comes with WACUP should work too.

dr0biwan commented 3 weeks ago

Apologies for posting on this closed issue but thought it best to clarify something from the above. wacup currently only uses a small sub-set of the plug-ins from the 5.666 installer for its x86 build & it no longer uses the winamp core. The install step that gets the old winamp installer isn't installing winamp as I think is being assumed & is just to acquire some of the plug-ins wanted.

ungive commented 3 weeks ago

Apologies for posting on this closed issue but thought it best to clarify something from the above. wacup currently only uses a small sub-set of the plug-ins from the 5.666 installer for its x86 build & it no longer uses the winamp core. The install step that gets the old winamp installer isn't installing winamp as I think is being assumed & is just to acquire some of the plug-ins wanted.

@dr0biwan Thanks for clarifying! I think it installed Winamp for me, when I installed it on my laptop, but I'm not sure.

Small side question, do you plan on improving the metadata that is reported to Windows by WACUP? Last time I tried the reporting was only with basic information, lacking e.g. an accurate reflection of the playback position.

dr0biwan commented 3 weeks ago

Is it just the timeline info missing for that or are there other things also needed? As I've just given it a quick try & assuming I'm providing the correct information I'm not seeing a progress bar in the discord ui.

[edit] I've now got the timeline info working :) The media-session-dump tool was useful once I stumbled upon that.

ungive commented 3 weeks ago

image Output of msd.exe: https://github.com/ungive/media-session-dump

That info is needed for a progress bar to show in the Discord status.

I've implemented this for a foobar2000 plugin 2 days ago, if you want a reference or an implementation example: https://github.com/ungive/foo_mediacontrol/blob/master/foobar2000/foo_mediacontrol/playback_listener.cpp

Hope that helps!

dr0biwan commented 2 weeks ago

Thanks for the info though I'd already got it working per my edit (was me not doing things correctly with the winrt calls). I also hooked up reporting the genre in case that was needed. Will have a newer wacup build out with the changes later this month.

ungive commented 2 weeks ago

Great stuff! Looking forward to it

hans-juergen commented 2 weeks ago

I just installed the latest WACUP 64-bit version, was not aware that there is one before. It works with Music Presence, I can wait for the missing progress bar and support for other skins than the classic look, too: 😉

image

Native scrobbling also works, great! 😎

image

dr0biwan commented 2 weeks ago

It's been out as a preview build for a bit over a month but has existed for a few years a beta only since it was fundamental to getting the x86 build to be able to drop the need for the winamp core a year or so back. That's good to know it also is being seen as well as scrobbling working.

Modern / winamp3 style skin support is still a long way off as I've got to create everything needed to support them. Any of the classic style skins (such as from https://skins.webamp.org/) should work with the x64 build without issue.

hans-juergen commented 2 weeks ago

Thanks for the explanation and the link to the Winamp Skin Museum, that should be enough choices for users who want something different than the standard skin.

I will update the Last.fm support FAQ about Winamp and WACUP with the new developments and also announce it on the Last.fm subreddit: https://support.last.fm/t/winamp-wacup-scrobbling/5645

How could old school users preferring the legacy desktop scrobbler plus its old Winamp plugin use that instead, simply by disabling the new native scrobbling option in WACUP?

@ungive: I think you can add a role for WACUP as supported media player in your server besides foobar2000 and MusicBee, or is something still missing?

ungive commented 2 weeks ago

@hans-juergen Added the roles for that

dr0biwan commented 2 weeks ago

How could old school users preferring the legacy desktop scrobbler plus its old Winamp plugin use that instead, simply by disabling the new native scrobbling option in WACUP?

My implementation is automatically disabled if the old plug-in is found whilst everything is loading. That only applies to the x86 build as the x64 build can't use the old plug-in. I also had a mode that helped to install the plug-in from the legacy lastfm installer but that was removed when I implemented my handling so manually copying the plug-in dll over is required to use it.

hans-juergen commented 2 weeks ago

The Last.fm support FAQ about Winamp / WACUP is updated now, hope I did not forget important news. Also posted about this in r/lastfm and crossposted it to r/winamp and r/WACUP mentioning Music Presence as well.

@ungive: Now that you can post on Reddit again, maybe you should announce your app on some other subreddits than only r/foobar2000? I think r/discordapp would be a fitting subreddit, as they sometimes have threads about Discord RPC implementations for music and a very large user base. Other relevant subreddits would probably be r/TIdal (no spelling mistake), r/truespotify (as r/spotify is only about playlists), r/AppleMusic, r/YoutubeMusic etc.

ungive commented 2 weeks ago

@hans-juergen I intend to do that slowly and in phases, not all at once, there's no rush for it. And I also want to work on browser, linux and scrobbling support. There's also individual reasons why I'm waiting with posting on certain subreddits: