ungive / discord-music-presence

The Discord music status that works with any media player
https://musicpresence.app
Other
229 stars 2 forks source link

[Bug] Update ignore Portable status #80

Closed saminationdj closed 1 week ago

saminationdj commented 1 week ago

Is there an existing issue for this?

Describe the bug

When using the in-app updater, it ignores where the current EXE is located and installs in %localappdata% location instead.

Reproduction Steps

...

Expected behavior

Install in the same location as the portable version has been extracted.

Screenshots

No response

Device Info

Operating system: Windows

Additional context

No response

saminationdj commented 1 week ago

This isn't a dig at you, but I hate that programs install in the appdata location. That's not its intended location on Windows.

ungive commented 1 week ago

I will definitely improve this once I work on a proper "portable" version. The ZIP as it is right now is identical to what is installed via the exe installer.

Updates are installed to the local appdata folder for simplicity: No elevated privileges are required during first installation and while installing updates automatically. It's also a central place to manage installed versions which just makes things easier, so it was the obvious choice to go about this.

But I definitely hear you and I will give the option to go fully portable without any leftovers in system directories in a future update (not too far in the future).

Since there is already an issue for this (#47) I will close this issue.