search

ungleich / dynamicweb

8 stars 22 forks source link

Newsletter/beta request confirmation email #299

Closed verysanghee closed 6 years ago

verysanghee commented 7 years ago

Problem The dcl logo in newsletter subscription email redirects to ungleich home (https://datacenterlight.ungleich.ch/) instead of dcl site

Goal The dcl logo should redirect to dcl

screen shot 2017-06-02 at 11 44 58
noeleont commented 7 years ago

@verysanghee thanks for this issue! You can use the Assignees on the right side to choose who you want to assign this issue as well as set the correct label for your issue - bug I guess in this case -.

verysanghee commented 7 years ago

Thanks for the tips! I'll assign all the email issues to you, maybe this way it's easier. You can be responsible for all mail issues.

pcoder commented 7 years ago

I think this may not be a bug really, and I think it works as expected. Here is my observation:

The code behind this is https://github.com/ungleich/dynamicweb/blob/master/datacenterlight/templates/datacenterlight/emails/request_access_confirmation.html#L78 which seems to correctly use the {{base_url}} for the logo.

During my tests to reproduce the bug, I never found the link of logo pointing to a url other than the host that generated the email.

pcoder commented 6 years ago

This issue is outdated. So, closing this.