search

ungoldman / gh-release-assets

Upload assets to a GitHub release
ISC License
10 stars 4 forks source link

Which node version supported? #14

Closed Semigradsky closed 2 years ago

Semigradsky commented 2 years ago

From changelog:

2.0.0

- BREAKING CHANGE: Update all deps which raises the minimum node version.

but there is no engines field in package.json.

bcomnes commented 2 years ago

Sorry, didn't have time to figure it out exactly. LTS is assumed and we should specify it in package.json. If it's not working on LTS it should be an issue (I think it is).

ungoldman commented 2 years ago

Hey @Semigradsky, sorry for the confusion. The minimum node version (12) is now explicitly set in the engines field in package.json (https://github.com/ungoldman/gh-release-assets/pull/17).

We are generally following the LTS maintenance schedule outlined in the official Node.js docs here:

https://nodejs.org/en/about/releases/

ungoldman commented 2 years ago

Fix released on npm in v2.0.1

Semigradsky commented 2 years ago

Looks like util-extend dependency can be replaced by native Object.assign.