Closed ungoldman closed 2 years ago
@paulcpederson or @bcomnes want me to tag you for PR reviews for this repo? I used to request reviews from people all the time but in this new and complex world I feel like I'm just annoying people if I do it.
Is the error code of standard getting swallowed by tap-arc?
Is the error code of standard getting swallowed by tap-arc?
The false positive linked to above was from an older PR (tap-spec). Nothing's changed on that end for a long time (years).
Anyway I think the syntax
standard && tape test/index.js | tap-spec
gets interpreted as
( standard ) && ( tape test/index.js | tap-spec )
so I don't think a tap parser would be able to swallow the exit code from standard in that context. could be wrong, as always 🤷
hey big fan, love what you've done with the place
tap-spec
(unmaintained, security warnings) withtap-arc
Sidenote: The tests weren't passing when I ran locally, but ci seemed to indicate things were fine. I did some digging and it looks like there were a bunch of standard warnings but the test suite still came back green, which is weird/concerning. Example:
From last job: https://github.com/ungoldman/gh-release-assets/runs/5561851927?check_suite_focus=true
Tests look okay for this one but I'm still a little concerned that there are false positives here or elsewhere, since I'm using the same config for github actions in most of my repos now.