search

ungoldman / gh-release-assets

Upload assets to a GitHub release
ISC License
10 stars 4 forks source link

bump to resolve security vuln #5

Closed jgravois closed 6 years ago

jgravois commented 6 years ago

https://nodesecurity.io/advisories/566

same as: https://github.com/hypermodules/gh-release/pull/72

i don't have push access to this repo though.

jgravois commented 6 years ago

tests are passing on travis for my fork... https://travis-ci.org/jgravois/gh-release-assets/builds/372171651

paulcpederson commented 6 years ago

I checkout out your branch and the tests passed, so no LGTM

paulcpederson commented 6 years ago

Thanks, @jgravois ! ❤️ ✨

jgravois commented 6 years ago

thx @paulcpederson!

any chance you could publish this as v1.1.2 or give me the 🔑s to take care of it? we're consuming in arcgis-rest-js and i'm tackling security vulnerability nags there.

paulcpederson commented 6 years ago

@bcomnes @ungoldman what do you think about adding @jgravois as an honorary hypermodules member?

ungoldman commented 6 years ago

@jgravois You are cordially invited!

jgravois commented 6 years ago

You are cordially invited!

thank you!

curtsy

released as v1.1.2 on GitHub. i encountered a ☠️ 403 when i ran npm publish

ungoldman commented 6 years ago

@jgravois hey, sorry about that. I added you as a collaborator on npm as well

ungoldman commented 6 years ago

I ran npm publish, 1.1.2 is on npm now. 🌈

jgravois commented 6 years ago

much appreciated!