ungoldman / module-init

:checkered_flag: Create a new node module with all the right stuff.
ISC License
71 stars 8 forks source link

Added TAP summarizer option. #12

Closed bcomnes closed 9 years ago

bcomnes commented 9 years ago

Faucet is great, but suffers from some compatibility issues on windows. Seems fair to offer some TAP summarizer options. I promise I'm not trying to turn this into yeoman

Flet commented 9 years ago

I concur with @bcomnes: faucet explodes on Windows when run on its own.

This does work in Windows though: tape test/*.js | faucet

The problem is when faucet tries to spawn tape (good ol' #2318 in joyent/node). So this gets around it by piping instead.

ungoldman commented 9 years ago

If that's the case I think we might as well just plain switch to tap-spec. The only reason I was using faucet instead was because it was less to write (standard && faucet vs standard && tape test/*.js | tap-spec). I don't think we need to overload the initialization options with competing tape output formatting modules.

Flet commented 9 years ago

faucet output looks pretty janky on Windows anyways. tap-spec looks nice though.

Flet commented 9 years ago

I don't get the expected/actual output using tap-spec on tests. Maybe that's a personal problem though.

ungoldman commented 9 years ago

@Flet what do you mean by expected/actual? can you elaborate? I don't think I get what you say you don't get

Flet commented 9 years ago

faucet:

image

tap-spec:

image

plain old tape:

image

Flet commented 9 years ago

ah, scottcorgan/tap-spec#29

Flet commented 9 years ago

Heh, npm install -g tap-spec@2.2.2 looks a lot better to me! :) image

From the issue above, looks like they are trying to work it out.

ungoldman commented 9 years ago

closing this in favor of defaulting to tap-spec unless there's a strong case for needing more than one tap output prettifier