search

ungoldman / module-init

:checkered_flag: Create a new node module with all the right stuff.
ISC License
71 stars 8 forks source link

Move linting to the end of the test chain #31

Closed bcomnes closed 9 years ago

bcomnes commented 9 years ago

Hypotheses: Style linting is important, but sometimes it just gets in the way when writing tests. Moving our linting to the end of the test chain helps avoid unnecessary style enforcement when writing tests.

Linting can help catch errors, but more often than not it's better to address those errors after running the test suite.

ungoldman commented 9 years ago

That makes sense. It's only in the current order because of @feross's What you might do if you're clever section in the standard readme.

@bcomnes mind updating the change log too?

ungoldman commented 9 years ago

Would probably be good to change it in the root package.json too.

ungoldman commented 9 years ago

Actually I've got some time and energy right now, I'll take care of the rest of this one. Thanks @bcomnes!

bcomnes commented 9 years ago

Oh yeah. Just wanted to make sure everything was cool first. :+1:

ungoldman commented 8 years ago

Reverting this as the linter is not just for style and will often catch syntax errors that will trip up tests. I think linter && test is the right order.