ungoogled-software / ungoogled-chromium-android

Android build for ungoogled-chromium
GNU General Public License v3.0
498 stars 43 forks source link

Bromite patches #103

Closed wchen342 closed 3 years ago

wchen342 commented 3 years ago

Hi @csagan5, I haven't been able to apply Add-bookmark-import-export-actions.patch since cr93, build fails with

../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java:776: error: method initialize in class DownloadLocationCustomView cannot be applied to given types;
                mCustomView.initialize(
                           ^
  required: int,long
  found: int,File,int,String
  reason: actual and formal argument lists differ in length
../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java:781: error: cannot find symbol
                Resources resources = mContext.getResources();
                                      ^
  symbol: variable mContext
../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java:1271: error: cannot find symbol
            ((Activity)window.getContext().get()).runOnUiThread(new Runnable() {
              ^
  symbol:   class Activity
  location: class BookmarkBridge

The last one is easy to solve but the first error I am not sure where you get the extra parameters from?

uazo commented 3 years ago

you are right.

The last one is easy to solve but the first error I am not sure where you get the extra parameters from?

we mixed changes between the Add-menu-item-to-bookmark-all-tabs.patch and the Add-bookmark-import-export-actions.patch. thanks for the tip

@csagan5 I'll fix it if you agree

csagan5 commented 3 years ago

@uazo please do; I also noticed something going on there.

csagan5 commented 3 years ago

FYI the fix has already been merged.

wchen342 commented 3 years ago

Looks good, thanks!