search

ungoogled-software / ungoogled-chromium-android

Android build for ungoogled-chromium
GNU General Public License v3.0
495 stars 42 forks source link

Request Desktop site error #26

Closed cleanerspam closed 4 years ago

cleanerspam commented 4 years ago

*Device info (please complete the following information):

*Is the bug related to extensions? No

*If not related to extensions, can the bug be reproduced with corresponding Chromium version? No

*Describe the bug When I enable desktop site on a site that I visited using duckduckgo.com instead of loading the site in desktop mode it reloads the previous page I.e.the search results and then I have to again navigate to my desired web site

*To Reproduce Steps to reproduce the behavior:

  1. Set duckduckgo as default
  2. Search "ublock chrome"
  3. Open the first result (opens in mobile view )
  4. Turn on desktop mode
  5. Browser goes back to duck result page and opens it in desktop mode

*Expected behavior It should reload the current webpage in desktop mode .

ScreenRecord Screenshot_20200806-075853426__01

Video (mediafire)

Additional context Only happened on DuckduckGo does not happens when google is default search provider

wchen342 commented 4 years ago

If this happens with plain chromium then it is not a ungoogled chromium bug.

wchen342 commented 4 years ago

Also I don't have 84.0.4044.138 as a version. Is that from Bromite?

cleanerspam commented 4 years ago

Also I don't have 84.0.4044.138 as a version. Is that from Bromite?

Sorry I forgot to change the whole version number of issue template Updated Now with correct info

wchen342 commented 4 years ago

So does it happen with plain Chromium exactly?

cleanerspam commented 4 years ago

It does not happens on Chromium Checked on version 81.0.4044.127

wchen342 commented 4 years ago

So turns out it happens with non extension version too. Probably some problem with the patches from main repo.

wchen342 commented 4 years ago

It is related to the flag fieldtrial_testing_like_official_build=true. But I need to figure out why before I can remove the flag.

wchen342 commented 4 years ago

Ok I figured out the fix is to enable a feature called ProactivelySwapBrowsingInstance. According to the comments there should be no downside of enabling this, except for probably some small increase in memory usage. Will be enabled by default in next version.

wchen342 commented 4 years ago

Resolved in 1812d02.