search

ungoogled-software / ungoogled-chromium-android

Android build for ungoogled-chromium
GNU General Public License v3.0
491 stars 43 forks source link

Extensions working upon install, and then not #48

Closed michel-m closed 3 years ago

michel-m commented 3 years ago

Please at least answer all questions marked with * below. Issues without answering these questions will be closed.

*Device info (please complete the following information):

*Is the bug related to extensions? Yes

*If not related to extensions, can the bug be reproduced with corresponding Chromium version? Yes/No

*Describe the bug Upon install of extensions (I have only tried uBlock origin and HTTPS everywhere), they work perfectly well, and then if I close the browser and open it again they don't work anymore. If I reinstall them they work, but will stop working if I close the browser and reopen it.

*To Reproduce Steps to reproduce the behavior:

  1. Install uBlock origin
  2. Search Startpage for "iPhone", for example
  3. No ads shown
  4. Close browser, open it again
  5. Search Startpage for "iPhone"
  6. Ads are shown (even though uBlock origin does still appear in chrome://extensions, and its settings pages are perfectly accessible)

*Expected behavior Extensions should work all the time once installed.

Screenshots N/A

Additional context N/A

wchen342 commented 3 years ago

Can confirm. Seems to have something to do with tabs.

wchen342 commented 3 years ago

Temporarily fixed in bbae620 until a better way is found. There is a minor bug that the first time you switch back and the tab got reloaded then medias will not display. A refresh will solve it.

michel-m commented 3 years ago

Thanks for letting me know! I'll let you decide whether to keep this issue open or not.

wchen342 commented 3 years ago

I will keep it open but don't expect it to be fully fixed any time soon. The underlying issue is quite complicated and I doubt it can be fixed without a rewrite of some core startup logics.

wchen342 commented 3 years ago

After making the fix of #34, this issue now becomes narrower, that extensions (not restricted to uBlock Origin) will not work only the first tab that being resumed. A refresh shall fix it. I will upload a new version soon, please test if possible.

michel-m commented 3 years ago

Tested, works perfectly, thank you very much! (Extensions don't seem to work in incognito tabs though, not sure if that's expected – it's a minor issue though.)

ghost commented 3 years ago

Can confirm as well. Thank you!

(Extensions don't seem to work in incognito tabs though, not sure if that's expected – it's a minor issue though.)

Isn't that by design, though?

wchen342 commented 3 years ago

Extensions are supposed to work in incognito tabs if you check an option (I think it's in the extension page), but I haven't implement that yet since I want to see whether it works on normal pages first.

Balachandarsmr commented 3 years ago

Switched from Firefox. Ublock origin working fine. Thanks for your great effort.