[BUG] Application crash

[wanlyg]

Please at least answer all questions marked with * below. Issues without answering these questions will be closed.

*Device info (please complete the following information):

• Device: xiaomi mi6
• OS: LineageOS 18.1 (Android 11)
• Arch: arm64
• Variant: Extensions
• Version: v88.0.4324.152-2

*Is the bug related to extensions? Yes

*If not related to extensions, can the bug be reproduced with corresponding Chromium version? Yes/No

*Describe the bug ①. When installing the avira plugin, the app crashes ②. When Violentmonkey is enabled, close tab crashes

*To Reproduce Steps to reproduce the behavior: for ①, 1.Only need to install avira . for ②, 1.Install Violentmonkey 2.Click to view all tabs 3.Close a tab

*Expected behavior A clear and concise description of what you expected to happen. Fix bug

Screenshots If applicable, add screenshots to help explain your problem. No Additional context Add any other context about the problem here.

Thank you very much for your work

[wchen342]

(2) seems to be the same as #59. I cannot reproduce it on -3. Please try when the version is released.

(1) is a different bug. I will fix it in next version.

EDIT: the release is out now.

[hbarsaiyan]

arm64 extension variant crashes on video playback in sites like Twitter (YouTube works fine though). I have no extensions installed. arm32 extension variant plays the video fine though. I have attatched the log below. Log_2021-02-17_18-35-36.txt

Apart from that the crash on closing tabs seems to be fixed 🎉. Thank you.

[wchen342]

@hbarsaiyan Does it happen with non-extension-support version?

[hbarsaiyan]

@wchen342 yes I can confirm it's happening on the non-extension arm64 variant also.

[wanlyg]

Confirmed that issue ② has been fixed in v88.0.4324.152-3 @wchen342

[wchen342]

@hbarsaiyan I think it is the GPU accleration on specific hardware. I remember Bromite used to have the same problem and I cannot reproduce on emulator or my Sony phone.

I will grab the bromite patch and compile a debug build for you to test.

[hbarsaiyan]

@hbarsaiyan I think it is the GPU accleration on specific hardware. I remember Bromite used to have the same problem and I cannot reproduce on emulator or my Sony phone.

I will grab the bromite patch and compile a debug build for you to test.

OK thank you very much.

[wchen342]

@hbarsaiyan Please try this apk and see whether it still crashes.

[ghost]

(2) seems to be the same as #59. I cannot reproduce it on -3. Please try when the version is released.

(1) is a different bug. I will fix it in next version.

EDIT: the release is out now.

Hey did https everywhere work for you? I can't test it :-(

[hbarsaiyan]

@hbarsaiyan Please try this apk and see whether it still crashes.

Sadly no, it still crashes. I had some other people also report the same bug 😣. Edit: the test apk is also suffering from the tab crash problem.

(2) seems to be the same as #59. I cannot reproduce it on -3. Please try when the version is released. (1) is a different bug. I will fix it in next version. EDIT: the release is out now.

Hey did https everywhere work for you? I can't test it :-(

Yes https everywhere is working fine.

[wchen342]

@hbarsaiyan Can you check whether the flag enable-image-reader is disabled? Also post the log please. The apk is a debug build so the output should tell where the crash happens.

EDIT: I may uploaded the wrong file. Let me check.

[wchen342]

Wrong file indeed. Can you try again? The link is the same.

[hbarsaiyan]

Wrong file indeed. Can you try again? The link is the same.

Disabling enable-image-reader fixed the problem 🎉 Strangely I had enabled it when I was on the arm32 extension build, but it does not work on arm64 variant. I then set it to default but that also did not work so I believe it is enabled by default on android P+ devices. BTW the build you sent also has the tab crash problem. I have attached the log below. Thank you. Log_2021-02-18_16-10-35.txt

[wchen342]

BTW the build you sent also has the tab crash problem

You mean the previous one? Because the later one should be a non-extension build.

I had enabled it when I was on the arm32 extension build, but it does not work on arm64 variant.

This is a specific problem with arm64, so only on some arm64 devices you need to disable that flag.

[hbarsaiyan]

BTW the build you sent also has the tab crash problem

You mean the previous one? Because the later one should be a non-extension build.

I had enabled it when I was on the arm32 extension build, but it does not work on arm64 variant.

This is a specific problem with arm64, so only on some arm64 devices you need to disable that flag.

But the package name on the second build you sent is org.ungoogled.chromium.extensions.stable 🤔

[wchen342]

Oh I think I knew what was going on. It was the CDN's cache..

Anyway since now I know the flag fixes the problem I will just include the patch in next release.

[wchen342]

(1) is fixed. But the extension doesn't have a standard popup, so after installation the icon in menu is not working.

Patch is included in .182.

[wchen342]

I haven't been able to figure out how the extension opens new tab. Some information from the extension developer will be helpful.

[wanlyg]

I cannot help you. But I need to point out that avira will create a new privacy window. The avira pop-up window sometimes does not work in the kiwi browser, but you can pop up the window by checking the desktop version of the webpage. even if you return to uncheck the desktop version. I can't test the computer version of Chrome, it may be a plug-in bug. @wchen342

[wchen342]

I tested it on desktop and it doesn't seem to open incognito window? I saw it open a normal tab. @kiwibrowser Do you remember how you made this work?

[wchen342]

Discussion moved to #66.