search

ungoogled-software / ungoogled-chromium-android

Android build for ungoogled-chromium
GNU General Public License v3.0
491 stars 43 forks source link

TriChrome Builds Broken Again #83

Closed lzlrd closed 3 years ago

lzlrd commented 3 years ago

*Device info (please complete the following information):

*Is the bug related to extensions? No

*If not related to extensions, can the bug be reproduced with corresponding Chromium version? No

*Describe the bug Ungoogled Chromium doesn't appear in the app drawer and WebView isn't registering.

*To Reproduce Steps to reproduce the behavior:

  1. Install the TriChrome variants of v89.0.4389.82-1 or v89.0.4389.90-1.

*Expected behavior The browser appearing in the app drawer and WebView being registered.

Screenshots n/a

Additional context v88.0.4324.182-2 works fine.

wchen342 commented 3 years ago

The cert seems right on the apks, not sure what was going on. Will try to investigate when building next version.

wchen342 commented 3 years ago

Can you try the following:

wchen342 commented 3 years ago

The problem is more complicated than I thought, there is a unknown problem with gn files. If possible please use ChromeModernPublic for now. This will take some time to fix.

lzlrd commented 3 years ago

Thanks for the fix earlier. 89.0.4389.114-2 successfully allowed the installation of TriChromeChrome, however WebView still fails to install with the error shown below:

And yes, I've installed 89.0.4389.114-2's TriChrome library.

PS: Is it not possible to build all TriChrome targets (in other words, WebView along with Library and Chrome)? Your TriChromeWebView builds have been unusually large and I suspect this is due to not being built alongside the relevant TriChromeLibrary. The current build of TriChromeWebView is around 100MB, which suggests that code code from the library isn't being used.

wchen342 commented 3 years ago

The webview is bigger probably because I turned off split modules to make extracted universal apk work. For Trichrome and ChromeModern now only have bundle targets which can only build aab files not apk, which means either I extract an universal apk with bundletool or you have to install aab files yourself with bundletool. The apk target for webview still exists so I will try turn on split modules and build again.

Webview cannot find library most likely because I changed library to be pure 64 bit but webview is built towards normal target. Can you try this library and see whether it works for webview? I cannot debug it locally because custom webview seems to not work on emulators.

lzlrd commented 3 years ago

The webview is bigger probably because I turned off split modules to make extracted universal apk work. For Trichrome and ChromeModern now only have bundle targets which can only build aab files not apk, which means either I extract an universal apk with bundletool or you have to install aab files yourself with bundletool. The apk target for webview still exists so I will try turn on split modules and build again.

I see, thanks for your swift response.

Webview cannot find library most likely because I changed library to be pure 64 bit but webview is built towards normal target. Can you try this library and see whether it works for webview? I cannot debug it locally because custom webview seems to not work on emulators.

This library works, yeah. I assume you plan on building the next TriChromeWebView as pure 64-bit (at least for arm64)?

In terms of testing it on an emulator, I may have an idea but I'll need to get back to you on that one in a few days (feel free to shoot me an email if I forget).

wchen342 commented 3 years ago

Can you try the new version and see whether it works?

Also I noticed I never had the right signatures on the trichrome version of webview. I will update a signed version soon and let me know whether it breaks the installation.

lzlrd commented 3 years ago

Can you try the new version and see whether it works?

Also I noticed I never had the right signatures on the trichrome version of webview. I will update a signed version soon and let me know whether it breaks the installation.

It works now, thanks. I'm also glad the size of WebView has shrunk down, alongside it being 64-bit.