search

ungoogled-software / ungoogled-chromium-archlinux

Arch Linux packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
338 stars 37 forks source link

Newest release update issue due to bad source code link. #267

Closed UX0l0l closed 1 month ago

UX0l0l commented 3 months ago

I tried updating ungoogled-chromium-bin on my arch install but it gave me this error message: ==> ERROR: Failure while downloading https://github.com/ungoogled-software/ungoogled-chromium-archlinux/releases/download/125.0.6422.60-1/ungoogled-chromium-125.0.6422.60-1-x86_64.pkg.tar.zst

This piqued my curiosity and I decided to investigate the error myself. Turns out, the actual link on the releases page here on the github page is https://github.com/ungoogled-software/ungoogled-chromium-archlinux/releases/download/125.0.6422.60/ungoogled-chromium-125.0.6422.60-1-x86_64.pkg.tar.zst, while in the PKGBUILD (as shown in the error) it is https://github.com/ungoogled-software/ungoogled-chromium-archlinux/releases/download/125.0.6422.60-1/ungoogled-chromium-125.0.6422.60-1-x86_64.pkg.tar.zst

You may not notice the difference, but the link on the github releases page actually lacks the package release (125.0.6422.60) while the PKGBUILD link has the release (125.0.6422.60-1) meaning the links are ever so slightly different, causing the error

I hope you are able to fix this issue soon

mikkasendke commented 3 months ago

same issue here (obviously) I'd love to see this resolved as well, thank you :)

networkException commented 3 months ago

argh sorry, got the tag name wrong. I'll push a fix

UX0l0l commented 3 months ago

thx a lot :)

networkException commented 3 months ago

not sure if aur helpers can handle the manual fix, a build for -2 is running tho

UX0l0l commented 3 months ago

I think I figured out the reason for this and an easy fix that doesn't involve any AUR or PKGBUILD changes.

If you go to the tags, you'll notice the latest release doesn't have the format (pkgver-pkgrel) like in the PKGBUILD, but simply (pkgver). All the previous releases have the (pkgver-pkgrel) format as their names except this one. Here's screenshots to explain what I mean:

Latest release:

Screenshot_20240521_104145_GitHub.jpg

The release before it:

Screenshot_20240521_104216_GitHub.jpg

PKGBUILD before and after:

Screenshot_20240521_104803_Bromite.jpg

Simply revert the PKGBUILD to what it was but add "-1" at the end of the release/tag name on github and that should solve the issue 100% and not cause any inconsistency with previous releases