ungoogled-software / ungoogled-chromium-debian

Debian, Ubuntu, and others packaging for ungoogled-chromium
386 stars 49 forks source link

README Rework #304

Closed ElectronicsArchiver closed 2 years ago

ElectronicsArchiver commented 2 years ago



[
 Please Check The **Preview** 
][Preview]



Badge Suggestions




Badge Changes



Badge Ask



Badge Robot


            No, I'm not a robot.            


    Yes, you are not the first.    


     I just made a PR template.     



PF4Public commented 2 years ago

What value does it bring for a barely maintained repository?

ElectronicsArchiver commented 2 years ago

To be more maintained.

No but what kind of question is that, changes don't change in meaning depending on how maintained the repository is.

I have used this repo many times and have been mislead by the documentation quite a bit so I thought I might as well improve it.

PF4Public commented 2 years ago

Sorry, if my question sounded offending, I didn't mean anything like that.

ElectronicsArchiver commented 2 years ago

Sorry, if my question sounded offending, I didn't mean anything like that.

I'm sorry as well~

Small writeup for design reasons:

ghost commented 2 years ago

Do not merge. I will review this later. I am currently trying to get this building.

ElectronicsArchiver commented 2 years ago

@braewoods So when is this later you were talking about?

ghost commented 2 years ago

I don't particularly like the approach taken here. The git root is used also for building packages directly so that was part of why I used a single file for all the documentation. In the event of a conflict between chromium and our own additions there would be problems.

Can you restructure your work under debian directory somewhere? Or even move them to a hidden folder? I also plan to remove Impish since it is EOL or close to it so I would prefer the references to it also be removed.

ElectronicsArchiver commented 2 years ago

I also plan to remove Impish since it is EOL or close to it so I would prefer the references to it also be removed.

Sure~

The git root is used also for building packages directly so that was part of why I used a single file for all the documentation. In the event of a conflict between chromium and our own additions there would be problems.

Well, are there any conflict even?

Also why are you building in the root anyways? Why not just have a Build folder like 99% of other projects?

Can you restructure your work under debian directory somewhere?

You want the Documentation folder in there, but the README as well?

Or even move them to a hidden folder?

.Documentation ?

ghost commented 2 years ago

Because this is how all Debian or Ubuntu packages are ultimately built. The debian folder is placed in the root of the upstream source code.

ElectronicsArchiver commented 2 years ago

How does that prevent a Build folder exactly?

The upstream would simply have to be cloned in said folder, same for the debian folder..

ElectronicsArchiver commented 2 years ago

Also what about the other 2 questions?

ghost commented 2 years ago

We used to expect people to copy the debian folder to somewhere else before attempting anything but I found it made it more difficult for me to experiment with changes and fixes.

ghost commented 2 years ago

Merged as a consolidated commit in another PR. For some reason a direct merge was modifying existing patches which was probably not intended.

ElectronicsArchiver commented 2 years ago

Merged as a consolidated commit in another PR.

So you are saying instead of telling me to reduce this commit to the documentation changes only or having me make a cherry picked branch you choose to copy paste my changes in #305?

While you @ElectronicsArchiver in the title that still robs me from the contributors history.

As you don't have an AUTHORS file I don't consider that a valid way of accepting my changes.

Please revert your pull request and let me adjust this one.

ghost commented 2 years ago

Reverted.

ElectronicsArchiver commented 2 years ago

@braewoods Thank you, I adjusted my PR branch to have the docs in .github you can open the PR again if you want.

PF4Public commented 2 years ago

While you @ElectronicsArchiver in the title that still robs me from the contributors history.

Is it so important to you? Are you after "contributors history" instead of "improving the documentation" after all? Why does "improving documentation" have to consist of 15 commits then?

ElectronicsArchiver commented 2 years ago

Why does "improving documentation" have to consist of 15 commits then?

It doesn't? I can squash them down if you want.

Is it so important to you? Are you after "contributors history" instead of "improving the documentation" after all?

Sorry I like being credited for the work I do. Or do you not like abiding by copyright law?

PF4Public commented 2 years ago

It doesn't? I can squash them down if you want.

Please be so kind. Also a commit message fully describing your efforts (not in 2 words) would be great. Thanks!