search

ungoogled-software / ungoogled-chromium-debian

Debian, Ubuntu, and others packaging for ungoogled-chromium
386 stars 49 forks source link

Build error #55

Closed berkley4 closed 4 years ago

berkley4 commented 4 years ago

Using debian amd64, building fails with.......

make[1]: Entering directory '/home/berkley4/ungoogled-chromium/build/src'
./tools/gn/bootstrap/bootstrap.py --skip-generate-buildfiles -j2
ninja: Entering directory `/home/berkley4/ungoogled-chromium/build/src/out/Release/gn_build'
ninja: error: build.ninja:34: bad $-escape (literal $ must be written as $$)
  cflags = -resource-dir= -resource-dir=$(clang-8 --print-resource-dir) ...
                                        ^ near here

This looks like it's related to https://github.com/ungoogled-software/ungoogled-chromium-debian/commit/462460d7f50cc01d3077710e641fc41e45f2c42f, as the following change to debian/rules allows the build to continue....

-export CXXFLAGS+=-resource-dir=$$($(CC) --print-resource-dir) \
+export CXXFLAGS+=-resource-dir=$(shell $(CC) --print-resource-dir) \

-export CPPFLAGS+=-resource-dir=$$($(CC) --print-resource-dir) \
+export CPPFLAGS+=-resource-dir=$(shell $(CC) --print-resource-dir) \

-export CFLAGS+=-resource-dir=$$($(CC) --print-resource-dir) \
+export CFLAGS+=-resource-dir=$(shell $(CC) --print-resource-dir) \