ungoogled-software / ungoogled-chromium-fedora

RPM build for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
33 stars 6 forks source link

Building latest version 96 is not working #22

Closed rkfox closed 2 years ago

rkfox commented 2 years ago

Build was working fine with the previous 94 version. Now I can't get it to build.


+ sed -i 's|exec "${THIS_DIR}/ninja-linux${LONG_BIT}"|exec "/usr/bin/ninja-build"|g' ../depot_tools/ninja
sed: can't read ../depot_tools/ninja: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.uWzfYL (%prep)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.uWzfYL (%prep)```
rkfox commented 2 years ago

I solved for my setup by reusing the old revision of depot-tools renamed to the new revision...

wchen342 commented 2 years ago

That's strange, OBS runs fine so the spec file shall be correct. Can you check whether that file exists in depot_tools tarball (I suppose you download it directly)? Also check whether that file is included in ungoogled-chromium's pruning list. Somethings file got pruned accidentally.

rkfox commented 2 years ago

I download depot_tools manually. Building from the spec file spits out a required revision of depot_tools. (The build process looks for a specific depot_tools folder like depot_tools-{revision}.) The previous revision is ~7.6mb and has depot_tools/ninja while the new required revision does not. The old revision still works as long as it is renamed to the new revision.

wchen342 commented 2 years ago

I just checked locally again, the file indeed exists in the depot_tools folder for the revision in spec file. Maybe your download is corrupted or something else deleted the file?