ungoogled-software / ungoogled-chromium-macos

macOS packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
252 stars 69 forks source link

Update to ungoogled-chromium 116.0.5845.179 #124

Closed hlgsdx closed 9 months ago

hlgsdx commented 10 months ago
PF4Public commented 9 months ago

Have you attempted building?

hlgsdx commented 9 months ago

Have you attempted building?

Yes, it compiles and runs fine locally on my MBP. 🙂

Also, there're two github actions ci running in my fork repo, both x64 and arm64. ( https://github.com/hlgsdx/eloston-chromium/actions )

PF4Public commented 9 months ago

@networkException Should we wait till those actions finish or merge right away?

PF4Public commented 9 months ago

@hlgsdx Would you be able to update to the latest tag in core repo?

hlgsdx commented 9 months ago

@hlgsdx Would you be able to update to the latest tag in core repo?

Sure, I'll check it out later today, since my mac is not around right now. 🍻

hlgsdx commented 9 months ago

Updated to chromium 116.0.5845.179, compiled and tested locally. Everything looks fine.

Shottr_2023-09-07_17-31-13_pjfr
PF4Public commented 9 months ago

Thanks @hlgsdx

@networkException Are tags here also manually created?

hlgsdx commented 9 months ago

Are tags here also manually created?

It seems that a new tag containing arm is needed to launch the github action workflow for arm64 architecture.

https://github.com/ungoogled-software/ungoogled-chromium-macos/blob/83fb80818a1d58b2321f92ea426d76754b95939e/.github/scripts/github_before_build.sh#L25-L26