Cubik65536 commented 7 months ago

Notes:

A submodule bump is made.
Some patches were refreshed.
- Two patches were removed as the targeted code from Chromium were removed. (P.S.: This is the first time for me to make these kind of changes, if I made something wrong, please point it out.)

Builds and runs fine locally.

Cubik65536 commented 7 months ago

By the way I do plan to try to contribute this project more actively to keep macOS version of Ungoogled Chromium up-to-date (this is one of my daily driver browser now). Still relatively new to these patches kind of stuff, if I've done something wrong, please point it out to me, looking forward to the future!

PF4Public commented 7 months ago

Thanks @Cubik65536 , sorry for the delay.

Cubik65536 commented 7 months ago

Thanks @Cubik65536 , sorry for the delay.

No problem 😃

Cubik65536 commented 7 months ago

@networkException sorry for the ping, but it seems that the ci are all finished (even for the tags) but no release is created and no dmg uploaded?

networkException commented 7 months ago

The build failed, ill look at this in a few hours

Cubik65536 commented 7 months ago

The build failed, ill look at this in a few hours

Got it. It seems that Ninja failed, I'm pretty sure I don't have that in my local env :/

I'll also take a look whenever I can.

benhaney commented 7 months ago

There's two issues that I'm seeing right now. One is causing an error half way through the build on any platform, and the other is stopping the arm build from ever really getting started.

The first issue is caused by https://github.com/chromium/chromium/commit/11065a962f6a15212ac1b021d19a0072c62108bc, which introduces the use of a symbol only available in the macOS 14 SDK, provided by Xcode 15. Fixing this should be as simple as updating your actions workflow to select Xcode 15.0.1 instead of 14.3.1

The second issue is caused by python 3.12 dropping the deprecated distutils, which provided the pkg_resources module that a Chromium build script used for arm builds. Github Actions macOS runners already updated to python 3.12, but the upstream Chromium fix for this (https://github.com/chromium/chromium/commit/da3f836905f6926533edd37495b238a9155e1984) is part of the 120 sources. I think the easiest thing to do here would be to temporarily backport that commit as an extra patch, unless you know a good way to make pkg_resources available again to the build environment.

Hopefully saves y'all some debugging efforts.

PF4Public commented 7 months ago

@Cubik65536 Would you be able to fix this according to @benhaney suggestions?

Cubik65536 commented 7 months ago

@Cubik65536 Would you be able to fix this according to @benhaney suggestions?

I’ll take a look at it this weekend.

Cubik65536 commented 7 months ago

@Cubik65536 Would you be able to fix this according to @benhaney suggestions?

ungoogled-software / ungoogled-chromium-macos

Update to ungoogled-chromium 119.0.6045.159 #131

132 is up for fixes