search

ungoogled-software / ungoogled-chromium-macos

macOS packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
252 stars 69 forks source link

Fix GitHub Action build failure since 119.0.6045.159 #132

Closed Cubik65536 closed 7 months ago

Cubik65536 commented 7 months ago

This Pull Request fixes the GitHub Action build failure introduced since #131 (update to Chromium & ungoogled-chromium 119.0.6045.159).

Cubik65536 commented 7 months ago

Some related info: https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/131#issuecomment-1833562087

PF4Public commented 7 months ago

Have you attempted building .199 by any chance?

Cubik65536 commented 7 months ago

Have you attempted building .199 by any chance?

I haven't, I will have to do that during the weekend because of the build time needed (I'm not pluged and moving around all along the day normally).

Cubik65536 commented 7 months ago

Can this be merged now? @PF4Public

downlz commented 7 months ago

Some related info: #131 (comment)

I build it today for Mac arm and it worked for me. Currently using Version 119.0.6045.159 (Official Build, ungoogled-chromium) (arm64) in my system.

networkException commented 7 months ago

Looks like there's another issue: bs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: html5lib. Do you need to install a parser library?

Cubik65536 commented 7 months ago

Looks like there's another issue: bs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: html5lib. Do you need to install a parser library?

At this point I'd add a pip3 install -U html5lib in the install dependency step and try to see if it solves it.

I can't test anything now, if the issue persist after fixing the action, I'll do further investigation.

I think the change is to small for open another PR, do any of you mind adding that instead of me? Sorry. @PF4Public @networkException

PF4Public commented 7 months ago

I think the change is to small for open another PR, do any of you mind adding that instead of me?

Done in 45ae81d9568d96900fa9e9112b9d53c566ef33ed

networkException commented 7 months ago

Did not work

Cubik65536 commented 7 months ago

Did not work

I'll test again locally.

PF4Public commented 7 months ago

Did not work

But workflows still run, is there something else that fails?

Cubik65536 commented 7 months ago

Did not work

But workflows still run, is there something else that fails?

It's just the limitation of the CI script. If the build fails, the action doesn't stop, and all the other "resumes" action just restart the entire build process and fail again.

Cubik65536 commented 7 months ago

I do suspect that the issue is caused by Python 3.12 because according to GitHub's docs, Python 3.12 is installed after the last update made here in October (which worked, with Python 3.11).

I will test locally with Python 3.11 again and then try with 3.12. If worse comes to worse, maybe revert to 3.11 temporarily.

downlz commented 7 months ago

Folks i made a release with .199. Currently understanding this project and looking forward for contribution. Here's the release file 119.0.6045.199 arm64 i have the following setup: Python - 3.9.6 xcode - 15.0.1

Cubik65536 commented 7 months ago

I do suspect that the issue is caused by Python 3.12 because according to GitHub's docs, Python 3.12 is installed after the last update made here in October (which worked, with Python 3.11).

I will test locally with Python 3.11 again and then try with 3.12. If worse comes to worse, maybe revert to 3.11 temporarily.

Both Python 3.11 and 3.12 works on my local environment... This is strange, I'll look further into the GitHub Action issue later. @PF4Public @networkException

benhaney commented 6 months ago

I do suspect that the issue is caused by Python 3.12 because according to GitHub's docs, Python 3.12 is installed after the last update made here in October (which worked, with Python 3.11).

I will test locally with Python 3.11 again and then try with 3.12. If worse comes to worse, maybe revert to 3.11 temporarily.

I think this is the right idea. I noticed that homebrew's python3 is still on 3.11 anyways, and the 3.12 version installed in the Actions runners is an official python release. I tried an ARM build in an Actions runner using homebrew's python3 instead and all the build problems went away. No need to separately mess with setuptools or html5lib, just:

- brew install coreutils ninja
+ brew install coreutils ninja python3 --overwrite
Cubik65536 commented 6 months ago

I do suspect that the issue is caused by Python 3.12 because according to GitHub's docs, Python 3.12 is installed after the last update made here in October (which worked, with Python 3.11). I will test locally with Python 3.11 again and then try with 3.12. If worse comes to worse, maybe revert to 3.11 temporarily.

I think this is the right idea. I noticed that homebrew's python3 is still on 3.11 anyways, and the 3.12 version installed in the Actions runners is an official python release. I tried an ARM build in an Actions runner using homebrew's python3 instead and all the build problems went away. No need to separately mess with setuptools or html5lib, just:

- brew install coreutils ninja
+ brew install coreutils ninja python3 --overwrite

Thanks for your help! This change is made in PR #133