ungoogled-software / ungoogled-chromium-macos

macOS packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
252 stars 69 forks source link

Update to ungoogled-chromium 119.0.6045.199 #133

Closed Cubik65536 closed 6 months ago

Cubik65536 commented 7 months ago

Builds and runs fine locally.

image

[!NOTE]
This works fine with local environment LLVM (clang) 17.0.6, Xcode 15.0.1 and Python 3.12 (3.11? I made a mistake and I'll have to check again). But I do suspect that if the GitHub Action for build will work. I still recommend to try and see if there's a fix from Chromium side though (that Python error in #132 is caused by vanilla Chromium code). I'm still investigating that issue.

Cubik65536 commented 7 months ago

I still can't figure out how that bs4.FeatureNotFound (https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/132#issuecomment-1834399414) issue was caused and no Chromium-relate issue reports/posts were found. Should we merge this and give it a go?


Extra info:

It is an issue caused by Chromium code, I seriously don't want to touch it unless necessary. The file that caused the issue haven't been changed by upstream for a few months, but there's other changes on that module, I don't know if it affects anything for now, still investigating the root cause.

Cubik65536 commented 6 months ago

/cc @PF4Public @networkException

I did a revert to Python 3.11 (following discussions in https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/132#issuecomment-1837273873) as an attempt to solve the build issues we have now. I do think we should give it a go.

We'll see if things will be better when updating to v120 coming around.

(I actually didn't build on Python 3.12, I made some mistakes configuring Python on my local environment, it's on me, I'll test later again).

Cubik65536 commented 6 months ago

Yeah revert to Python 3.11 seems to solve the issue... I'll try to test with Python 3.12 when v120 comes and see if things have been improved. Or we might have to keep Python 3.11 for our CI for a moment.

downlz commented 6 months ago

@Cubik65536 What is the process of publishing Mac arm release to this repo. I want to build and contribute over here. https://github.com/downlz/ungoogled-chromium-macos/releases/tag/119.0.6045.199

Cubik65536 commented 6 months ago

@Cubik65536 What is the process of publishing Mac arm release to this repo. I want to build and contribute over here. downlz/ungoogled-chromium-macos@119.0.6045.199 (release)

This repo never publish manually any release assets (you might found out that all the new releases were published by github-actions).

The process is:

[!TIP] Learn more from README

  1. we keep the ungoogled-chromium submodule of this repo up to date (ungoogled-chromium is the https://github.com/ungoogled-software/ungoogled-chromium repo, where they tries to keep up with upstream Google Chromium)
  2. update/add/remove patches if needed
  3. make sure it compiles & runs with submodule bump (and patches modification if there is one)
  4. make a pull request
  5. PR gets merged, and the admin push a tag
  6. wait for the CI of this repo to run to compile both x64 and arm64 versions and release automatically

The project is not small and we are effectively compiling arm binary on GitHub CI's x64 machine, so it is slow.

PF4Public commented 6 months ago

@downlz @Cubik65536 It is possible to manually publish binaries in ungoogled-chromium-binaries, but it would not make much sense doing so if your binaries are produced similarly as the ones via GitHub actions from this repository.

Cubik65536 commented 6 months ago

@downlz @Cubik65536 It is possible to manually publish binaries in ungoogled-chromium-binaries, but it would not make much sense doing so if your binaries are produced similarly as the ones via GitHub actions from this repository.

Yeah, the problem is sometimes the arm build takes so much longer... Maybe host our own ARM Mac for CI? (Providers like MacStadium do provides free access for open source projects, but it is not easy to get into the program and I don't know at what level admins at ungoogled software want to go through that process.)

Maybe upload a version to PR is another way to do that, but I don't think it's that often to be in a hurry to update, and I personally can't compile a x64 version every time just to attach it to the PR.