search

ungoogled-software / ungoogled-chromium-macos

macOS packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
252 stars 69 forks source link

ci(build): Use `setup-python` for Python 3.11 setup #139

Closed Cubik65536 closed 5 months ago

Cubik65536 commented 5 months ago

This PR changes the Python setup source of the building GitHub Action from HomeBrew to actions/setup-python and keeps the Python version at 3.11.

This is a more "permanent" fix to the issue bs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: html5lib. Do you need to install a parser library? when building with GitHub CI.

Works in the forked repo.

AlaisterLeung commented 5 months ago

I think other build jobs also need to be modified to prevent potential problems in the future.

Cubik65536 commented 5 months ago

I think other build jobs also need to be modified to prevent potential problems in the future.

The weird thing is, if it's not added, theoretically the other's won't work, and my run in the forked repo here, which is in sync with the main branch (and doesn't contain this fix) still works fine (till now). So I'm not even sure if this fix is now needed.

Maybe just try to rerun the release action in this repo? @networkException

Cubik65536 commented 5 months ago

Close for now because it seems that reruns (x86-64) (arm64) worked.

We'll just keep monitoring the situation then.