ci: Allow a single CI run to build & release for both x86-64 and arm64

[Cubik65536]

This PR changes the ci process and allows one GitHub Action run to build both x86-64 and arm64 builds for ungoogled-chromium macOS.

It also uses the actions/setup-python action to setup Python 3.11 environment. This is an attempt to permanently "fix" the bs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: html5lib. Do you need to install a parser library? issue when building with GitHub CI and when Python 3.12 (and above, prehaps?) is used.

TODO List:

• [x] Lock in Python 3.11 environment for building
• [x] Allow the same action run to build both x86-64 and arm64 builds (TESTING)
• [x] Prevent the same action run from downloading the source assets twice before building for each arch.
• [x] Publish binaries for both x86-64 and arm64 in an single release. (TESTING)

[Cubik65536]

A related question @networkException , will we still have two individual releases (for two arch) or a single release that contains binaries for both x86-64 and arm64?

[networkException]

Whatever is easier for you

[Cubik65536]

I'll try to put it in a single release then. We might also have to change something with our brew cask (not very familiar with that, will take a deeper look later).

[Cubik65536]

Testing here (just a manual trigger, w/o a release) and here (push to a tag, w/ a release).

[jorgehezd]

Hi, I still receive the error:

An error occurred. (Error code: 9) (Extra code: 0) Learn more https://support.9oo91e.qjz9zk/chrome?p=update_error Version 120.0.6099.216 (Official Build, ungoogled-chromium) (arm64)

On 14 Jan 2024, at 20:51, Cubik65536 @.***> wrote:

Testing here (just a manual trigger, w/o a release) https://github.com/iXORTech/ungoogled-chromium-macos/actions/runs/7523608741 and here (push to a tag, w/ a release) https://github.com/iXORTech/ungoogled-chromium-macos/actions/runs/7523617042.

— Reply to this email directly, view it on GitHub https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/142#issuecomment-1891222721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWR5O3EVHNDQFZ53KF3YMCLYOSKRNAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGIZDENZSGE. You are receiving this because you are subscribed to this thread.

[Cubik65536]

Hi, I still receive the error: An error occurred. (Error code: 9) (Extra code: 0) Learn more <support.9oo91e.qjz9zk/chrome?p=update_error> Version 120.0.6099.216 (Official Build, ungoogled-chromium) (arm64) On 14 Jan 2024, at 20:51, Cubik65536 @.***> wrote: Testing here (just a manual trigger, w/o a release) <iXORTech/ungoogled-chromium-macos/actions/runs/7523608741> and here (push to a tag, w/ a release) <iXORTech/ungoogled-chromium-macos/actions/runs/7523617042>. — Reply to this email directly, view it on GitHub <#142 (comment)>, or unsubscribe <github.com/notifications/unsubscribe-auth/AWR5O3EVHNDQFZ53KF3YMCLYOSKRNAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGIZDENZSGE>. You are receiving this because you are subscribed to this thread.

First, this is probably the least place you should report this issue. Second, check description of #134.

[jorgehezd]

I’m really sorry. My bad. Thanks.

On 15 Jan 2024, at 11:42, Cubik65536 @.***> wrote:

Hi, I still receive the error: An error occurred. (Error code: 9) (Extra code: 0) Learn more <support.9oo91e.qjz9zk/chrome?p=update_error https://support.9oo91e.qjz9zk/chrome?p=update_error> Version 120.0.6099.216 (Official Build, ungoogled-chromium) (arm64) On 14 Jan 2024, at 20:51, Cubik65536 @.***> wrote: Testing here (just a manual trigger, w/o a release) <iXORTech/ungoogled-chromium-macos/actions/runs/7523608741 https://github.com/iXORTech/ungoogled-chromium-macos/actions/runs/7523608741> and here (push to a tag, w/ a release) <iXORTech/ungoogled-chromium-macos/actions/runs/7523617042 https://github.com/iXORTech/ungoogled-chromium-macos/actions/runs/7523617042>. — Reply to this email directly, view it on GitHub <#142 (comment) https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/142#issuecomment-1891222721>, or unsubscribe <github.com/notifications/unsubscribe-auth/AWR5O3EVHNDQFZ53KF3YMCLYOSKRNAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGIZDENZSGE https://github.com/notifications/unsubscribe-auth/AWR5O3EVHNDQFZ53KF3YMCLYOSKRNAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGIZDENZSGE>. You are receiving this because you are subscribed to this thread.

First, this is probably the least place you should report this issue. Second, check description of #134 https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/134.

— Reply to this email directly, view it on GitHub https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/142#issuecomment-1892573772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWR5O3C2UNQ2ZBOJE5UUUKLYOVTBZAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3TGNZXGI. You are receiving this because you commented.

[Cubik65536]

The test without release worked. A second with release test here.

[PF4Public]

A second with release test here.

Did it work in the end? There is an error:

Annotations 1 error Release macOS binaries of Ungoogled Chromium ENOENT: no such file or directory, open './github_release_note.md'

[Cubik65536]

A second with release test here.

Did it work in the end? There is an error:

Annotations 1 error Release macOS binaries of Ungoogled Chromium ENOENT: no such file or directory, open './github_release_note.md'

No it didn’t, will have a fix.

[Cubik65536]

The action w/ release worked (finally!) and here's the corresponding test release.

Now ready for review.

[Cubik65536]

I think I will skip 120.0.6099.224 and directly update to 121.0.6167.75 after this PR have been merged and when 121.0.6167.75 gets released.

[PF4Public]

@networkException any objections to merging?

[PF4Public]

Thanks @Cubik65536

[claudiodekker]

Figured I'd mention that this PR also changed the release names to Ungoogled-Chromium macOS <tag>, since that wasn't necessarily an expected change.

Not really a big deal, and some might actually prefer it this way, but arguably it's slightly less descriptive on the project overview page or anywhere else the releases might be displayed where space is limited:

[Cubik65536]

Figured I'd mention that this does change the release names to "Ungoogled-Chromium macOS " as well.

While it's not really a big deal and some might actually prefer it, it is arguably slightly less distinctive on the project overview page. In either case, it's a change that wasn't necessarily requested, so I figured I'd bring it up just in case:

I made that change on purpose because usually the version is after the software name, and it is not a very big deal (in my opinion) because usually what we want to download from there is definitely just the "latest", and if someone is looking for a specific version, they'd rather look at the release list, where the version number would not be hidden.

We might want still to change that - considering the ungoogled-chromium macOS repo is the only one who put the software name in the release title (the others use only the version number), I'm open to any opinion.

[claudiodekker]

Yeah, you're absolutely right, and my apologies for my initial wording on that comment. I didn't intend to come across as biased for or against the change either way. It was just something that stood out to me as an unexpected change when I was preparing my automated signing builds to be compatible with this change, and something that might've easily slipped through with others as well.

As for the version-number only argument: This is also my experience, as generally projects consider it kind of a given that you're aware as to what project you're looking at / are browsing in anyway, but I'll leave it up to the maintainers to make those kinds of decisions :)