Closed Cubik65536 closed 5 months ago
Do we need these checks in PRs? I mean attempting to build.
Do we need these checks in PRs? I mean attempting to build.
Technically we don't, because it's nearly the same process as the release action (except that this one doesn't create an release) and we'll actually just wait for CI do the exact same thing twice.
Normally if the build works on the local environment and the initial process of the GitHub CI works, there's nothing that's going to fail (ideally), so we don't really have to wait for the PR check to finish (otherwise it will just take too long considering the arm build takes in average an entire day to complete).
Maybe we should exclude building on PRs then?
Maybe we should exclude building on PRs then?
We could, I kept it when writing the new action script because it was there and sometime it was just skipped.
Would you like to disable it from building in another PR, so that we could merge this one?
Would you like to disable it from building in another PR, so that we could merge this one?
Ok I will make the change.
Would you like to disable it from building in another PR, so that we could merge this one?
done
Thanks!
@Cubik65536 I think you said you'd be willing to maintain the repo yourself already, if thats still the case I'd invite you and grant you access. You can always contact me for questions of course and because you'd be the only maintainer for now PRs will also require a core team member approval currently
@Cubik65536 I think you said you'd be willing to maintain the repo yourself already, if thats still the case I'd invite you and grant you access.
Yes I'm still interested in being a maintainer for the project :)
You can always contact me for questions of course and because you'd be the only maintainer for now PRs will also require a core team member approval currently
No problem!
Welcome!
I guess the best way to try your new push privileges is to create the tag for this version :)
Welcome!
I guess the best way to try your new push privileges is to create the tag for this version :)
https://github.com/ungoogled-software/ungoogled-chromium-macos/tree/121.0.6167.85 🎉
Thanks!
to create the tag
Shouldn't they be created via workflows?
they're not created via workflows in any repo of the org afaik
to create the tag
Shouldn't they be created via workflows?
A tag creation (push to tag) it what triggers the workflow that build and release the binaries.
Notes:
ungoogled-chromium/macos/disable-rust-qr-code-generator.patch
is added to revert the Rust QR code generator shipped with [5064208].Builds and runs fine locally.