search

ungoogled-software / ungoogled-chromium-macos

macOS packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
252 stars 69 forks source link

A small suggestion for the Release Notes #146

Closed 577 closed 4 months ago

577 commented 5 months ago

Since the release title already includes the version and timestamp, it might be unnecessary to repeat this information in the release body, especially since the two timestamps do not match.

ScreenShot_20240128_hJkbuelfpBd4gihF

Simply delete these two lines.

https://github.com/ungoogled-software/ungoogled-chromium-macos/blob/4853bf036f660e1e5eeae52577613031d12b814b/.github/scripts/github_generate_release_note.sh#L17-L18

Cubik65536 commented 5 months ago

Yeah it is an unexpected problem to have it mismatched (I introduced this bug and haven't found it) and I do plan to remove these in the next update.

My plan is to just remove entirely the epoch timestamp from the release (from tag, title, and body), and also just use the chromium_version + ungoogled_revision (in this case, just the 121.0.6167.85-1.1) for both the tag and the release title, so that it behaves in the same way as the other repos in the org. (As mentioned here a bit (sort of))

Any opinions on this? /cc @networkException @PF4Public

networkException commented 5 months ago

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

Cubik65536 commented 5 months ago

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

For now, we shouldn't need to rerun CIs unless we're changing the CI script and just want to test it. And I don't see any cases where there will be rebuilds (with the old script, it's possible that multiple releases will be created, it won't happen again).

I will make this change in the next update then.

claudiodekker commented 4 months ago

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

They were added in https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/92, perhaps @kramred has any recollection of it if they're around?