ungoogled-software / ungoogled-chromium-macos

macOS packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
252 stars 69 forks source link

Use arm64 LLVM when building UGC on Apple Silicon #151

Closed Cubik65536 closed 3 months ago

Cubik65536 commented 4 months ago

(This can still be viewed as a part of the works to improve compiling efficiency)

As for now, even if we build ungoogled-chromium-macos on Apple Silicon (arm64), an x86-64 version of LLVM is still used to compile. I think we should try to use arm64 LLVM in this case instead, so no translation for binaries are needed.

This might consist of appending different entries to downloads.ini while running build script.

Any opinions on this? /cc @networkException @PF4Public

PF4Public commented 4 months ago

@Cubik65536 Do you expect any downsides for this approach? Looks like there are none. If that's the case, then it is definitely an improvement!

Cubik65536 commented 4 months ago

@Cubik65536 Do you expect any downsides for this approach? Looks like there are none. If that's the case, then it is definitely an improvement!

I don't expect any downsides for this, except we'll have to generate the downloads.ini on fly while running the build script (which is actually not really a downside in my opinion).